Skip to content

Commit 1f4d80b

Browse files
committed
Linear retriever modified to work as intended
1 parent c18034b commit 1f4d80b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/linear/LinearRetrieverBuilder.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ public final class LinearRetrieverBuilder extends CompoundRetrieverBuilder<Linea
6363
args -> {
6464
List<LinearRetrieverComponent> retrieverComponents = (List<LinearRetrieverComponent>) args[0];
6565
int rankWindowSize = args[1] == null ? RankBuilder.DEFAULT_RANK_WINDOW_SIZE : (int) args[1];
66-
float minScore = args[2] == null ? DEFAULT_MIN_SCORE : (float) args[2];
6766
List<RetrieverSource> innerRetrievers = new ArrayList<>();
6867
float[] weights = new float[retrieverComponents.size()];
6968
ScoreNormalizer[] normalizers = new ScoreNormalizer[retrieverComponents.size()];
@@ -74,7 +73,7 @@ public final class LinearRetrieverBuilder extends CompoundRetrieverBuilder<Linea
7473
normalizers[index] = component.normalizer;
7574
index++;
7675
}
77-
return new LinearRetrieverBuilder(innerRetrievers, rankWindowSize, weights, normalizers, minScore);
76+
return new LinearRetrieverBuilder(innerRetrievers, rankWindowSize, weights, normalizers, DEFAULT_MIN_SCORE);
7877
}
7978
);
8079

@@ -196,6 +195,7 @@ public String getName() {
196195
return NAME;
197196
}
198197

198+
@Override
199199
public void doToXContent(XContentBuilder builder, Params params) throws IOException {
200200
int index = 0;
201201
if (innerRetrievers.isEmpty() == false) {
@@ -211,6 +211,5 @@ public void doToXContent(XContentBuilder builder, Params params) throws IOExcept
211211
builder.endArray();
212212
}
213213
builder.field(RANK_WINDOW_SIZE_FIELD.getPreferredName(), rankWindowSize);
214-
builder.field(RetrieverBuilder.MIN_SCORE_FIELD.getPreferredName(), minScore);
215214
}
216215
}

0 commit comments

Comments
 (0)