Removed redundant tests

Author: Kubik42

server/src/test/java/org/elasticsearch/index/mapper/KeywordFieldMapperTests.java

@@ -64,6 +64,8 @@
 import static org.hamcrest.Matchers.greaterThan;
 import static org.hamcrest.Matchers.hasSize;
 import static org.hamcrest.Matchers.instanceOf;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 public class KeywordFieldMapperTests extends MapperTestCase {
 
@@ -1064,103 +1066,6 @@ public void testFieldTypeDefault_IndexedFalseDocValuesFalse() throws IOException
         assertFalse(mapper.fieldType().hasDocValuesSkipper());
     }
 
-    public void test_isIgnoreAboveSet_returns_true_when_ignore_above_is_provided() throws IOException {
-        // given
-        MapperService mapperService = createSytheticSourceMapperService(mapping(b -> {
-            b.startObject("potato");
-            b.field("type", "keyword");
-            b.field("ignore_above", 123);
-            b.endObject();
-        }));
-
-        // when
-        KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("potato");
-
-        // then
-        assertTrue(mapper.fieldType().ignoreAbove().isSet());
-    }
-
-    public void test_isIgnoreAboveSet_returns_false_when_ignore_above_is_missing() throws IOException {
-        // given
-        MapperService mapperService = createSytheticSourceMapperService(mapping(b -> {
-            b.startObject("potato");
-            b.field("type", "keyword");
-            b.endObject();
-        }));
-
-        // when
-        KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("potato");
-
-        // then
-        assertFalse(mapper.fieldType().ignoreAbove().isSet());
-    }
-
-    public void test_value_is_not_ignored_when_it_exceeds_ignore_above_and_field_is_not_a_multi_field() throws IOException {
-        // given
-        MapperService mapperService = createSytheticSourceMapperService(mapping(b -> {
-            b.startObject("potato");
-            b.field("type", "keyword");
-            b.field("ignore_above", 1);
-            b.endObject();
-        }));
-
-        // when
-        KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("potato");
-
-        // then
-        assertFalse(
-            mapper.fieldType()
-                .ignoreAbove()
-                .isIgnored("this value will trip ignore_above, but bc keyword is not a multi field this value will not be ignored")
-        );
-    }
-
-    public void test_value_is_ignored_when_it_exceeds_ignore_above_and_field_is_a_multi_field() throws IOException {
-        // given
-        MapperService mapperService = createSytheticSourceMapperService(mapping(b -> {
-            b.startObject("potato").field("type", "text");
-            {
-                b.startObject("fields");
-                {
-                    b.startObject("tomato").field("type", "keyword");
-                    b.field("ignore_above", 1);
-                    b.endObject();
-                }
-                b.endObject();
-            }
-            b.endObject();
-        }));
-
-        // when
-        KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("potato.tomato");
-
-        // then
-        assertTrue(mapper.fieldType().ignoreAbove().isIgnored("this value is too long and will be ignored"));
-    }
-
-    public void test_value_is_not_ignored_when_it_does_not_exceed_ignore_above_and_field_is_a_multi_field() throws IOException {
-        // given
-        MapperService mapperService = createSytheticSourceMapperService(mapping(b -> {
-            b.startObject("potato").field("type", "text");
-            {
-                b.startObject("fields");
-                {
-                    b.startObject("tomato").field("type", "keyword");
-                    b.field("ignore_above", 123);
-                    b.endObject();
-                }
-                b.endObject();
-            }
-            b.endObject();
-        }));
-
-        // when
-        KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("potato.tomato");
-
-        // then
-        assertFalse(mapper.fieldType().ignoreAbove().isIgnored("this value is too short to be ignored"));
-    }
-
     public void test_value_is_stored_when_it_exceeds_ignore_above_and_field_is_not_a_multi_field() throws IOException {
         // given
         MapperService mapperService = createSytheticSourceMapperService(mapping(b -> {
@@ -1207,32 +1112,6 @@ public void test_value_is_not_stored_when_it_exceeds_ignore_above_and_field_is_a
         assertThat(doc.rootDoc().getField(mapper.fieldType().syntheticSourceFallbackFieldName()), Matchers.nullValue());
     }
 
-    public void test_value_does_not_exceed_ignore_above_and_field_is_a_multi_field() throws IOException {
-        // given
-        MapperService mapperService = createSytheticSourceMapperService(mapping(b -> {
-            b.startObject("potato").field("type", "text");
-            {
-                b.startObject("fields");
-                {
-                    b.startObject("tomato").field("type", "keyword");
-                    b.field("ignore_above", 123);
-                    b.endObject();
-                }
-                b.endObject();
-            }
-            b.endObject();
-        }));
-
-        // when
-        KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("potato.tomato");
-        ParsedDocument doc = mapperService.documentMapper().parse(source(b -> { b.field("potato", "this value is short"); }));
-
-        // then
-
-        // we don't expect to store anything extra when ignore_above isn't tripped as we can rely on doc_values for source
-        assertThat(doc.rootDoc().getField(mapper.fieldType().syntheticSourceFallbackFieldName()), Matchers.nullValue());
-    }
-
     public void test_value_exceeds_ignore_above_when_synthetic_source_disabled() throws IOException {
         // given
         final MapperService mapperService = createMapperService(mapping(b -> {