Fix analyzer and tests

Author: carlosdelest

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java

@@ -169,7 +169,6 @@
 import static org.elasticsearch.xpack.esql.core.type.DataType.TIME_DURATION;
 import static org.elasticsearch.xpack.esql.core.type.DataType.UNSUPPORTED;
 import static org.elasticsearch.xpack.esql.core.type.DataType.VERSION;
-import static org.elasticsearch.xpack.esql.core.type.DataType.isString;
 import static org.elasticsearch.xpack.esql.core.type.DataType.isTemporalAmount;
 import static org.elasticsearch.xpack.esql.telemetry.FeatureMetric.LIMIT;
 import static org.elasticsearch.xpack.esql.type.EsqlDataTypeConverter.maybeParseTemporalAmount;
@@ -1670,8 +1669,8 @@ private static Expression processVectorFunction(org.elasticsearch.xpack.esql.cor
             List<Expression> args = vectorFunction.arguments();
             List<Expression> newArgs = new ArrayList<>();
             for (Expression arg : args) {
-                if (arg.resolved()) {
-                    if (arg.foldable() && arg.dataType().isNumeric()) {
+                if (arg.resolved() && arg.dataType().isNumeric()) {
+                    if (arg.foldable()) {
                         Object folded = arg.fold(FoldContext.small() /* TODO remove me */);
                         if (folded instanceof List) {
                             // Convert to floats so blocks are created accordingly
@@ -1685,7 +1684,7 @@ private static Expression processVectorFunction(org.elasticsearch.xpack.esql.cor
                             newArgs.add(denseVector);
                             continue;
                         }
-                    } else if (arg.dataType().isNumeric() || isString(arg.dataType())) {
+                    } else {
                         // add casting function
                         newArgs.add(new ToDenseVector(arg.source(), arg));
                         continue;

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java

@@ -2434,10 +2434,10 @@ private void checkDenseVectorImplicitCastingSimilarityFunction(String similarity
         assertEquals("similarity", alias.name());
         var similarity = as(alias.child(), VectorSimilarityFunction.class);
         var left = as(similarity.left(), FieldAttribute.class);
-        var queryVector = as(similarity.right(), ToDenseVector.class);
-        assertEquals(DataType.DENSE_VECTOR, queryVector.dataType());
-        var refAttr = as(queryVector.children().get(0), ReferenceAttribute.class);
-        assertThat(refAttr.name(), is("query"));
+        assertThat(List.of("float_vector", "byte_vector"), hasItem(left.name()));
+        var right = as(similarity.right(), Literal.class);
+        assertThat(right.dataType(), is(DENSE_VECTOR));
+        assertThat(right.value(), equalTo(expectedElems));
     }
 
     public void testDenseVectorEvalCastingSimilarityFunctions() {