[8.x] Downgrade cluster.routing.allocation.type deprecation to a warning (#124785)

This setting is not getting removed in ES 9.0, so its usage should not generate
a critical deprecation warning.

See ES-11224

Author: arteam

server/src/main/java/org/elasticsearch/cluster/ClusterModule.java

@@ -109,7 +109,7 @@ public class ClusterModule extends AbstractModule {
         DESIRED_BALANCE_ALLOCATOR,
         Function.identity(),
         Property.NodeScope,
-        Property.Deprecated
+        Property.DeprecatedWarning
     );
 
     private final ClusterService clusterService;

server/src/test/java/org/elasticsearch/cluster/ClusterModuleTests.java

@@ -188,7 +188,7 @@ public void testRegisterShardsAllocator() {
         Settings settings = Settings.builder().put(ClusterModule.SHARDS_ALLOCATOR_TYPE_SETTING.getKey(), "custom").build();
         ClusterModule module = newClusterModuleWithShardsAllocator(settings, "custom", FakeShardsAllocator::new);
         assertEquals(FakeShardsAllocator.class, module.shardsAllocator.getClass());
-        assertCriticalWarnings(
+        assertWarnings(
             "[cluster.routing.allocation.type] setting was deprecated in Elasticsearch and will be removed in a future release."
         );
     }
@@ -218,15 +218,15 @@ public void testUnknownShardsAllocator() {
             )
         );
         assertEquals("Unknown ShardsAllocator [dne]", e.getMessage());
-        assertCriticalWarnings(
+        assertWarnings(
             "[cluster.routing.allocation.type] setting was deprecated in Elasticsearch and will be removed in a future release."
         );
     }
 
     public void testShardsAllocatorFactoryNull() {
         Settings settings = Settings.builder().put(ClusterModule.SHARDS_ALLOCATOR_TYPE_SETTING.getKey(), "bad").build();
         expectThrows(NullPointerException.class, () -> newClusterModuleWithShardsAllocator(settings, "bad", () -> null));
-        assertCriticalWarnings(
+        assertWarnings(
             "[cluster.routing.allocation.type] setting was deprecated in Elasticsearch and will be removed in a future release."
         );
     }

server/src/test/java/org/elasticsearch/cluster/routing/allocation/ClusterRebalanceRoutingTests.java

@@ -703,7 +703,7 @@ public void beforeAllocation(RoutingAllocation allocation) {
                 }
             }
         );
-        assertCriticalWarnings(
+        assertWarnings(
             "[cluster.routing.allocation.type] setting was deprecated in Elasticsearch and will be removed in a future release."
         );
 

server/src/test/java/org/elasticsearch/cluster/routing/allocation/IndexBalanceTests.java

@@ -448,7 +448,7 @@ public void testRebalanceShouldNotPerformUnnecessaryMovesWithMultipleConcurrentR
             .build();
 
         final var allocationService = createAllocationService(settings);
-        assertCriticalWarnings(
+        assertWarnings(
             "[cluster.routing.allocation.type] setting was deprecated in Elasticsearch and will be removed in a future release."
         );
 

server/src/test/java/org/elasticsearch/cluster/routing/allocation/ThrottlingAllocationTests.java

@@ -199,7 +199,7 @@ public void testThrottleIncomingAndOutgoing() {
             EmptyClusterInfoService.INSTANCE,
             snapshotsInfoService
         );
-        assertCriticalWarnings(
+        assertWarnings(
             "[cluster.routing.allocation.type] setting was deprecated in Elasticsearch and will be removed in a future release."
         );
         logger.info("Building initial routing table");

server/src/test/java/org/elasticsearch/snapshots/InternalSnapshotsInfoServiceTests.java

@@ -361,7 +361,7 @@ public IndexShardSnapshotStatus.Copy getShardSnapshotStatus(SnapshotId snapshotI
                     .build(),
                 snapshotsInfoService
             );
-            assertCriticalWarnings(
+            assertWarnings(
                 "[cluster.routing.allocation.type] setting was deprecated in Elasticsearch and will be removed in a future release."
             );
             applyClusterState(

server/src/test/java/org/elasticsearch/snapshots/SnapshotResiliencyTests.java

@@ -2204,7 +2204,7 @@ public RecyclerBytesStreamOutput newNetworkBytesStream() {
                         .build(),
                     snapshotsInfoService
                 );
-                assertCriticalWarnings(
+                assertWarnings(
                     "[cluster.routing.allocation.type] setting was deprecated in Elasticsearch and will be removed in a future release."
                 );
                 rerouteService = new BatchedRerouteService(clusterService, allocationService::reroute);