Fix tests

Author: svilen-mihaylov-elastic

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/ParserUtils.java

@@ -62,9 +62,7 @@ public static <T> List<T> visitList(ParseTreeVisitor<?> visitor, List<? extends
 
         List<T> results = new ArrayList<>(contexts.size());
         for (ParserRuleContext context : contexts) {
-            // TODO: revert
-            var result = visitor.visit(context);
-            results.add(clazz.cast(result));
+            results.add(clazz.cast(visitor.visit(context)));
         }
         return results;
     }

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java

@@ -3490,30 +3490,6 @@ private void assertEmptyEsRelation(LogicalPlan plan) {
         assertThat(esRelation.output(), equalTo(NO_FIELDS));
     }
 
-    public void testResolveRerankInferenceId1() {
-        assumeTrue("Requires RERANK command", EsqlCapabilities.Cap.RERANK.isEnabled());
-
-        // Substring function is named, should work.
-        LogicalPlan plan = analyze("""
-            FROM movies METADATA _score
-              | WHERE QSTR("star wars")
-              | RERANK "star wars" ON title, str=SUBSTRING(overview, 0, 100), actors WITH rerankerInferenceId""", "mapping-books.json");
-        Rerank rerank = as(as(plan, Limit.class).child(), Rerank.class);
-        assertThat(rerank.inferenceId(), equalTo(string("reranking-inference-id")));
-    }
-
-    public void testResolveRerankInferenceId2() {
-        assumeTrue("Requires RERANK command", EsqlCapabilities.Cap.RERANK.isEnabled());
-
-        // Substring function is unnamed, should fail.
-        LogicalPlan plan = analyze("""
-            FROM movies METADATA _score
-              | WHERE QSTR("star wars")
-              | RERANK "star wars" ON title, SUBSTRING(overview, 0, 100), actors WITH rerankerInferenceId""", "mapping-books.json");
-        Rerank rerank = as(as(plan, Limit.class).child(), Rerank.class);
-        assertThat(rerank.inferenceId(), equalTo(string("reranking-inference-id")));
-    }
-
     public void testResolveRerankInferenceId() {
         assumeTrue("Requires RERANK command", EsqlCapabilities.Cap.RERANK.isEnabled());
 
@@ -3635,6 +3611,19 @@ public void testResolveRerankFields() {
             assertThat(rerank.scoreAttribute(), equalTo(getAttributeByName(relation.output(), MetadataAttribute.SCORE)));
         }
 
+        {
+            // Unnamed field.
+            try {
+                LogicalPlan plan = analyze("""
+                    FROM books METADATA _score
+                    | WHERE title:"food"
+                    | RERANK "food" ON title, SUBSTRING(description, 0, 100), yearRenamed=year WITH `reranking-inference-id`
+                    """, "mapping-books.json");
+            } catch (ParsingException ex) {
+                assertThat(ex.getMessage(), containsString("line 3:36: mismatched input '(' expecting {'=', ',', '.', 'with'}"));
+            }
+        }
+
         {
             VerificationException ve = expectThrows(
                 VerificationException.class,