Removing the data stream settings feature flag (#128594)

Author: masseyke

modules/data-streams/src/main/java/org/elasticsearch/datastreams/DataStreamsPlugin.java

@@ -26,7 +26,6 @@
 import org.elasticsearch.action.datastreams.lifecycle.GetDataStreamLifecycleAction;
 import org.elasticsearch.action.datastreams.lifecycle.PutDataStreamLifecycleAction;
 import org.elasticsearch.client.internal.OriginSettingClient;
-import org.elasticsearch.cluster.metadata.DataStream;
 import org.elasticsearch.cluster.metadata.IndexNameExpressionResolver;
 import org.elasticsearch.cluster.node.DiscoveryNodes;
 import org.elasticsearch.common.io.stream.NamedWriteableRegistry;
@@ -285,10 +284,8 @@ public List<RestHandler> getRestHandlers(
         handlers.add(new RestGetDataStreamOptionsAction());
         handlers.add(new RestPutDataStreamOptionsAction());
         handlers.add(new RestDeleteDataStreamOptionsAction());
-        if (DataStream.LOGS_STREAM_FEATURE_FLAG) {
-            handlers.add(new RestGetDataStreamSettingsAction());
-            handlers.add(new RestUpdateDataStreamSettingsAction());
-        }
+        handlers.add(new RestGetDataStreamSettingsAction());
+        handlers.add(new RestUpdateDataStreamSettingsAction());
         return handlers;
     }
 

rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_data_stream_settings.json

@@ -5,8 +5,7 @@
       "description":"Gets a data stream's settings"
     },
     "stability":"stable",
-    "visibility": "feature_flag",
-    "feature_flag": "logs_stream",
+    "visibility": "public",
     "headers":{
       "accept": [ "application/json"]
     },

rest-api-spec/src/main/resources/rest-api-spec/api/indices.put_data_stream_settings.json

@@ -5,8 +5,7 @@
       "description":"Updates a data stream's settings"
     },
     "stability":"stable",
-    "visibility": "feature_flag",
-    "feature_flag": "logs_stream",
+    "visibility": "public",
     "headers":{
       "accept": [ "application/json"]
     },

server/src/main/java/org/elasticsearch/action/datastreams/GetDataStreamAction.java

@@ -435,11 +435,9 @@ public XContentBuilder toXContent(
                     builder.endArray();
                     builder.endObject();
                 }
-                if (DataStream.LOGS_STREAM_FEATURE_FLAG) {
-                    builder.startObject(SETTINGS_FIELD.getPreferredName());
-                    dataStream.getSettings().toXContent(builder, params);
-                    builder.endObject();
-                }
+                builder.startObject(SETTINGS_FIELD.getPreferredName());
+                dataStream.getSettings().toXContent(builder, params);
+                builder.endObject();
 
                 builder.startObject(DataStream.FAILURE_STORE_FIELD.getPreferredName());
                 builder.field(FAILURE_STORE_ENABLED.getPreferredName(), failureStoreEffectivelyEnabled);