Skip to content

Commit 22f89a2

Browse files
committed
Removed skip markers from CONTAINS function test cases - wrongfully assumed it was a marker for documentation. But it's used to ignore the test cases. Re-enabling the tests and fixing them.
1 parent 4c43deb commit 22f89a2

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/resources/string.csv-spec

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ emp_no:integer | name:keyword
389389
;
390390

391391

392-
contains#[skip:-9.2.99,reason:new string function added in 9.3]
392+
contains
393393
// tag::contains[]
394394
ROW a = "hello"
395395
| EVAL has_ll = CONTAINS(a, "ll")
@@ -402,28 +402,28 @@ hello | true
402402
// end::contains-result[]
403403
;
404404

405-
containsFail#[skip:-9.2.99,reason:new string function added in 9.3]
405+
containsFail
406406
row a = "hello" | eval a_ll = contains(a, "int");
407407

408408
a:keyword | a_ll:boolean
409409
hello | false
410410
;
411411

412-
containsLongerSubstr#[skip:-9.2.99,reason:new string function added in 9.3]
412+
containsLongerSubstr
413413
row a = "hello" | eval a_ll = contains(a, "farewell");
414414

415415
a:keyword | a_ll:boolean
416416
hello | false
417417
;
418418

419-
containsSame#[skip:-9.2.99,reason:new string function added in 9.3]
419+
containsSame
420420
row a = "hello" | eval a_ll = contains(a, "hello");
421421

422422
a:keyword | a_ll:boolean
423423
hello | true
424424
;
425425

426-
containsWithSubstring#[skip:-9.2.99,reason:new string function added in 9.3]
426+
containsWithSubstring
427427
from employees | where emp_no <= 10010 | eval f_s = substring(last_name, 2) | eval f_l = contains(last_name, f_s) | keep emp_no, last_name, f_s, f_l;
428428
ignoreOrder:true
429429

@@ -440,33 +440,33 @@ emp_no:integer | last_name:keyword | f_s:keyword | f_l:boolean
440440
10010 | Piveteau | iveteau | true
441441
;
442442

443-
containsUtf16Emoji#[skip:-9.2.99,reason:new string function added in 9.3]
443+
containsUtf16Emoji
444444
row a = "🐱Meow!🐶Woof!" | eval f_s = substring(a, 2) | eval f_l = contains(a, f_s);
445445

446446
a:keyword | f_s:keyword | f_l:boolean
447447
🐱Meow!🐶Woof! | Meow!🐶Woof! | true
448448
;
449449

450-
containsNestedCase#[skip:-9.2.99,reason:new string function added in 9.3]
450+
containsNestedCase
451451
row a = "hello" | eval a_ll = CASE(contains(a, "ll"), "success","fail");
452452

453453
a:keyword | a_ll:keyword
454454
hello | success
455455
;
456456

457-
containsNestSubstring#[skip:-9.2.99,reason:new string function added in 9.3]
457+
containsNestSubstring
458458
row a = "hello" | eval a_ll = contains(substring(a, 2), "ll");
459459

460460
a:keyword | a_ll:boolean
461461
hello | true
462462
;
463463

464-
containsWarnings#[skip:-9.2.99,reason:new string function added in 9.3]
464+
containsWarnings
465465

466466
from hosts | where host=="epsilon" | eval l1 = contains(host_group, "ate"), l2 = contains(description, "ate") | keep l1, l2;
467467
ignoreOrder:true
468-
warning:Line 1:80: evaluation of [contains(description, \"ate\")] failed, treating result as null. Only first 20 failures recorded.
469-
warning:Line 1:80: java.lang.IllegalArgumentException: single-value function encountered multi-value
468+
warning:Line 1:82: evaluation of [contains(description, \"ate\")] failed, treating result as null. Only first 20 failures recorded.
469+
warning:Line 1:82: java.lang.IllegalArgumentException: single-value function encountered multi-value
470470

471471
l1:boolean | l2:boolean
472472
true | null

0 commit comments

Comments
 (0)