Skip to content

Commit 23d92f0

Browse files
committed
Documenting changes done to copied test method due to inflexibility / visibility of methods / constructors.
1 parent 7492fad commit 23d92f0

File tree

1 file changed

+5
-1
lines changed
  • x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue

1 file changed

+5
-1
lines changed

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvContainsTests.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,11 @@ private static void bytesRefs(List<TestCaseSupplier> suppliers) {
286286
}));
287287
}
288288

289-
// Adjusted from static method anyNullIsNull in {@code AbstractScalarFunctionTestCase#}
289+
// Adjusted from static method anyNullIsNull in {@code AbstractFunctionTestCase#}
290+
// - changed logic to expect a Boolean as an outcome and alternative evaluators (IsNullEvaluator, ConstantTrue)
291+
// - constructor TestCase that's used has default access which we can't access, using public constructor variant as a replacement
292+
// - Added prefix to generated tests for my sanity.
293+
// - changed construction of new lists by copying them and updating the entries where necessary instead of regenerating
290294
protected static List<TestCaseSupplier> anyNullIsNull(
291295
List<TestCaseSupplier> testCaseSuppliers,
292296
ExpectedType expectedType,

0 commit comments

Comments
 (0)