Skip to content

Commit 26b30d7

Browse files
authored
Drop faulty assertion in TransportService (#86843)
We introduced an assertion in #85131 to check the assumption that there are no pending non-local response handlers when the `TransportService` shuts down. We later discovered that this assertion rarely tripped, which we fixed in #86315, but that fix did not go into 8.2 so there are still rare failures on this branch. This commit drops the faulty assertion in 8.2. Relates #86293
1 parent 6f43380 commit 26b30d7

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

server/src/main/java/org/elasticsearch/transport/TransportService.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,10 +300,6 @@ protected void doStop() {
300300
final TransportResponseHandler<?> handler = holderToNotify.handler();
301301
final var targetNode = holderToNotify.connection().getNode();
302302

303-
// Assertion only holds for TcpTransport only because other transports (used in tests) may not implement the proper
304-
// close-connection behaviour. TODO fix this.
305-
assert transport instanceof TcpTransport == false || targetNode.equals(localNode) : targetNode + " vs " + localNode;
306-
307303
final var exception = new SendRequestTransportException(
308304
targetNode,
309305
holderToNotify.action(),

0 commit comments

Comments
 (0)