Merge branch 'main' into views_rest_crud

Author: craigtaverner

docs/changelog/138745.yaml

@@ -0,0 +1,5 @@
+pr: 138745
+summary: Disk usage don't include synthetic `_id` postings
+area: Distributed
+type: enhancement
+issues: []

docs/reference/aggregations/search-aggregations-metrics-percentile-rank-aggregation.md

@@ -49,8 +49,8 @@ The response will look like this:
  "aggregations": {
     "load_time_ranks": {
       "values": {
-        "500.0": 55.0,
-        "600.0": 64.0
+        "500.0": 90.01,
+        "600.0": 100.0
       }
     }
   }
@@ -60,7 +60,7 @@ The response will look like this:
 % TESTRESPONSE[s/"500.0": 55.0/"500.0": 55.00000000000001/]
 % TESTRESPONSE[s/"600.0": 64.0/"600.0": 64.0/]
 
-From this information you can determine you are hitting the 99% load time target but not quite hitting the 95% load time target
+From this information you can determine you are hitting the 99% load time target but not quite hitting the 95% load time target.
 
 ## Keyed Response [_keyed_response_5]
 

docs/reference/enrich-processor/network-direction-processor.md

@@ -9,7 +9,7 @@ mapped_pages:
 
 Calculates the network direction given a source IP address, destination IP address, and a list of internal networks.
 
-The network direction processor reads IP addresses from [Elastic Common Schema (ECS)][Elastic Common Schema (ECS)](ecs://reference/index.md)) fields by default. If you use the ECS, only the `internal_networks` option must be specified.
+The network direction processor reads IP addresses from [Elastic Common Schema (ECS)](ecs://reference/index.md) fields by default. If you use the ECS, only the `internal_networks` option must be specified.
 
 $$$network-direction-options$$$
 

server/src/main/java/org/elasticsearch/action/admin/indices/diskusage/IndexDiskUsageAnalyzer.java

@@ -56,6 +56,7 @@
 import org.elasticsearch.core.CheckedConsumer;
 import org.elasticsearch.core.IOUtils;
 import org.elasticsearch.index.codec.postings.ES812PostingsFormat;
+import org.elasticsearch.index.mapper.SyntheticIdField;
 import org.elasticsearch.index.shard.ShardId;
 import org.elasticsearch.index.store.LuceneFilesExtensions;
 
@@ -368,6 +369,12 @@ void analyzeInvertedIndex(SegmentReader reader, IndexDiskUsageStats stats) throw
             if (terms == null) {
                 continue;
             }
+            if (SyntheticIdField.hasSyntheticIdAttributes(field.attributes())) {
+                // Synthetic _id field doesn't have an inverted index stored on disk,
+                // but it pretends to have one on the read path by setting IndexOptions.DOCS
+                assert SyntheticIdField.NAME.equals(field.getName()) : "Expected only synthetic id fields to have synthetic id attribute";
+                continue;
+            }
             // It's expensive to look up every term and visit every document of the postings lists of all terms.
             // As we track the min/max positions of read bytes, we just visit the two ends of a partition containing
             // the data. We might miss some small parts of the data, but it's an good trade-off to speed up the process.