Skip to content

Commit 279a880

Browse files
authored
Unmute testPartialResults (#137056)
Relate #131481
1 parent ea36c8a commit 279a880

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

muted-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -372,9 +372,6 @@ tests:
372372
- class: org.elasticsearch.xpack.ml.integration.InferenceIT
373373
method: testInferClassificationModel
374374
issue: https://github.com/elastic/elasticsearch/issues/133448
375-
- class: org.elasticsearch.xpack.esql.action.CrossClusterQueryWithPartialResultsIT
376-
method: testPartialResults
377-
issue: https://github.com/elastic/elasticsearch/issues/131481
378375
- class: org.elasticsearch.xpack.ml.integration.ClassificationIT
379376
method: testWithCustomFeatureProcessors
380377
issue: https://github.com/elastic/elasticsearch/issues/134001

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterQueryWithPartialResultsIT.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,17 +102,20 @@ private void assertClusterSuccess(EsqlQueryResponse resp, String clusterAlias, i
102102

103103
public void testPartialResults() throws Exception {
104104
populateIndices();
105-
EsqlQueryRequest request = new EsqlQueryRequest();
106-
request.query("FROM ok*,fail*,*:ok*,*:fail* | KEEP id, fail_me | LIMIT 1000");
107-
request.includeCCSMetadata(randomBoolean());
108105
{
106+
EsqlQueryRequest request = new EsqlQueryRequest();
107+
request.query("FROM ok*,fail*,*:ok*,*:fail* | KEEP id, fail_me | LIMIT 1000");
108+
request.includeCCSMetadata(randomBoolean());
109109
request.allowPartialResults(false);
110110
Exception error = expectThrows(Exception.class, () -> runQuery(request).close());
111111
error = EsqlTestUtils.unwrapIfWrappedInRemoteException(error);
112112

113113
assertThat(error, instanceOf(IllegalStateException.class));
114114
assertThat(error.getMessage(), containsString("Accessing failing field"));
115115
}
116+
EsqlQueryRequest request = new EsqlQueryRequest();
117+
request.query("FROM ok*,fail*,*:ok*,*:fail* | KEEP id, fail_me | LIMIT 1000");
118+
request.includeCCSMetadata(randomBoolean());
116119
request.allowPartialResults(true);
117120
try (var resp = runQuery(request)) {
118121
assertTrue(resp.isPartial());
@@ -134,6 +137,8 @@ public void testPartialResults() throws Exception {
134137
for (String cluster : List.of(LOCAL_CLUSTER, REMOTE_CLUSTER_1, REMOTE_CLUSTER_2)) {
135138
assertClusterFailure(resp, cluster, "Accessing failing field");
136139
}
140+
} catch (Exception e) {
141+
throw new AssertionError("failed to execute query", e);
137142
}
138143
}
139144

0 commit comments

Comments
 (0)