Rename testTransportRoundTripsWithTwoDigitFractions (#123160)

prdoyle · web-flow · commit 27b8fd7f0af3 · 2025-02-21T16:45:08.000Z
diff --git a/server/src/test/java/org/elasticsearch/common/unit/ByteSizeValueTests.java b/server/src/test/java/org/elasticsearch/common/unit/ByteSizeValueTests.java
@@ -538,10 +538,11 @@ public void testBWCTransportFormat() throws IOException {
         }
     }
 
-    public void testTwoDigitTransportRoundTrips() throws IOException {
+    public void testTransportRoundTripsWithTwoDigitFractions() throws IOException {
         for (var tv : List.of(TransportVersion.current(), BYTE_SIZE_VALUE_ALWAYS_USES_BYTES, BYTE_SIZE_VALUE_ALWAYS_USES_BYTES_90)) {
             for (var desiredUnit : ByteSizeUnit.values()) {
                 if (desiredUnit == ByteSizeUnit.BYTES) {
+                    // Can't have a fraction of a byte!
                     continue;
                 }
                 checkTransportRoundTrip(ByteSizeValue.parseBytesSizeValue("23" + desiredUnit.getSuffix(), "test"), tv);

Original file line number	Diff line number	Diff line change
`@@ -538,10 +538,11 @@ public void testBWCTransportFormat() throws IOException {`
`538`	`538`	`}`
`539`	`539`	`}`
`540`	`540`
`541`		`- public void testTwoDigitTransportRoundTrips() throws IOException {`
	`541`	`+ public void testTransportRoundTripsWithTwoDigitFractions() throws IOException {`
`542`	`542`	`for (var tv : List.of(TransportVersion.current(), BYTE_SIZE_VALUE_ALWAYS_USES_BYTES, BYTE_SIZE_VALUE_ALWAYS_USES_BYTES_90)) {`
`543`	`543`	`for (var desiredUnit : ByteSizeUnit.values()) {`
`544`	`544`	`if (desiredUnit == ByteSizeUnit.BYTES) {`
	`545`	`+ // Can't have a fraction of a byte!`
`545`	`546`	`continue;`
`546`	`547`	`}`
`547`	`548`	`checkTransportRoundTrip(ByteSizeValue.parseBytesSizeValue("23" + desiredUnit.getSuffix(), "test"), tv);`