Skip to content

Commit 2818298

Browse files
committed
Fix naming of helper methods
1 parent 94bb978 commit 2818298

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2116,41 +2116,41 @@ private void testFullTextFunctionsCurrentlyUnsupportedBehaviour(String functionI
21162116
}
21172117

21182118
public void testFullTextFunctionsNullArgs() throws Exception {
2119-
testFullTextFunctionNullArgs("match(null, \"query\")", "first");
2120-
testFullTextFunctionNullArgs("match(title, null)", "second");
2121-
testFullTextFunctionNullArgs("qstr(null)", "");
2122-
testFullTextFunctionNullArgs("kql(null)", "");
2119+
checkFullTextFunctionNullArgs("match(null, \"query\")", "first");
2120+
checkFullTextFunctionNullArgs("match(title, null)", "second");
2121+
checkFullTextFunctionNullArgs("qstr(null)", "");
2122+
checkFullTextFunctionNullArgs("kql(null)", "");
21232123
if (EsqlCapabilities.Cap.MULTI_MATCH_FUNCTION.isEnabled()) {
2124-
testFullTextFunctionNullArgs("multi_match(null, title)", "first");
2125-
testFullTextFunctionNullArgs("multi_match(\"query\", null)", "second");
2124+
checkFullTextFunctionNullArgs("multi_match(null, title)", "first");
2125+
checkFullTextFunctionNullArgs("multi_match(\"query\", null)", "second");
21262126
}
21272127
if (EsqlCapabilities.Cap.TERM_FUNCTION.isEnabled()) {
2128-
testFullTextFunctionNullArgs("term(null, \"query\")", "first");
2129-
testFullTextFunctionNullArgs("term(title, null)", "second");
2128+
checkFullTextFunctionNullArgs("term(null, \"query\")", "first");
2129+
checkFullTextFunctionNullArgs("term(title, null)", "second");
21302130
}
21312131
}
21322132

2133-
private void testFullTextFunctionNullArgs(String functionInvocation, String argOrdinal) throws Exception {
2133+
private void checkFullTextFunctionNullArgs(String functionInvocation, String argOrdinal) throws Exception {
21342134
assertThat(
21352135
error("from test | where " + functionInvocation, fullTextAnalyzer),
21362136
containsString(argOrdinal + " argument of [" + functionInvocation + "] cannot be null, received [null]")
21372137
);
21382138
}
21392139

21402140
public void testFullTextFunctionsConstantQuery() throws Exception {
2141-
testFullTextFunctionsConstantQuery("match(title, category)", "second");
2142-
testFullTextFunctionsConstantQuery("qstr(title)", "");
2143-
testFullTextFunctionsConstantQuery("kql(title)", "");
2141+
checkFullTextFunctionsConstantQuery("match(title, category)", "second");
2142+
checkFullTextFunctionsConstantQuery("qstr(title)", "");
2143+
checkFullTextFunctionsConstantQuery("kql(title)", "");
21442144
if (EsqlCapabilities.Cap.MULTI_MATCH_FUNCTION.isEnabled()) {
2145-
testFullTextFunctionsConstantQuery("multi_match(category, body)", "first");
2146-
testFullTextFunctionsConstantQuery("multi_match(concat(title, \"world\"), title)", "first");
2145+
checkFullTextFunctionsConstantQuery("multi_match(category, body)", "first");
2146+
checkFullTextFunctionsConstantQuery("multi_match(concat(title, \"world\"), title)", "first");
21472147
}
21482148
if (EsqlCapabilities.Cap.TERM_FUNCTION.isEnabled()) {
2149-
testFullTextFunctionsConstantQuery("term(title, tags)", "second");
2149+
checkFullTextFunctionsConstantQuery("term(title, tags)", "second");
21502150
}
21512151
}
21522152

2153-
private void testFullTextFunctionsConstantQuery(String functionInvocation, String argOrdinal) throws Exception {
2153+
private void checkFullTextFunctionsConstantQuery(String functionInvocation, String argOrdinal) throws Exception {
21542154
assertThat(
21552155
error("from test | where " + functionInvocation, fullTextAnalyzer),
21562156
containsString(argOrdinal + " argument of [" + functionInvocation + "] must be a constant")

0 commit comments

Comments
 (0)