@@ -22,9 +22,7 @@ public void testCombineInnerRetrieverResultsCalculatesWeightedSum() throws IOExc
2222 ScoreNormalizer [] normalizers = new ScoreNormalizer [] { IdentityScoreNormalizer .INSTANCE , IdentityScoreNormalizer .INSTANCE };
2323 float minScore = 0f ;
2424
25- LinearRetrieverBuilder builder = new LinearRetrieverBuilder (
26- sources , rankWindowSize , weights , normalizers , minScore
27- );
25+ LinearRetrieverBuilder builder = new LinearRetrieverBuilder (sources , rankWindowSize , weights , normalizers , minScore );
2826
2927 ScoreDoc [] left = new ScoreDoc [] { new ScoreDoc (5 , 1.0f , 0 ), new ScoreDoc (6 , 2.0f , 0 ) };
3028 ScoreDoc [] right = new ScoreDoc [] { new ScoreDoc (5 , 3.0f , 0 ), new ScoreDoc (6 , 1.0f , 0 ), new ScoreDoc (7 , 0.5f , 0 ) };
@@ -56,39 +54,34 @@ public void testCombineAndFilterWithMinScore() throws IOException {
5654 ScoreNormalizer [] normalizers = new ScoreNormalizer [] { IdentityScoreNormalizer .INSTANCE , IdentityScoreNormalizer .INSTANCE };
5755 final float minScoreThreshold = 1.5f ;
5856
59- LinearRetrieverBuilder builder = new LinearRetrieverBuilder (
60- sources , rankWindowSize , weights , normalizers , minScoreThreshold
61- );
62- assertEquals (minScoreThreshold , builder .getMinScore (), 0f );
57+ LinearRetrieverBuilder builder = new LinearRetrieverBuilder (sources , rankWindowSize , weights , normalizers , minScoreThreshold );
58+ assertEquals (minScoreThreshold , builder .getMinScore (), 0f );
6359
6460 ScoreDoc [] left = new ScoreDoc [] { new ScoreDoc (0 , 1.0f , 0 ), new ScoreDoc (1 , 0.8f , 0 ) };
6561 ScoreDoc [] right = new ScoreDoc [] { new ScoreDoc (0 , 2.0f , 0 ), new ScoreDoc (1 , 0.6f , 0 ), new ScoreDoc (2 , 1.8f , 0 ) };
6662
6763 RankDoc [] combinedRankDocs = builder .combineInnerRetrieverResults (List .of (left , right ), false );
6864 assertEquals ("Combined docs before filtering" , 3 , combinedRankDocs .length );
6965
70- List <RankDoc > filteredDocs = Stream .of (combinedRankDocs )
71- .filter (rd -> rd .score >= builder .getMinScore ())
72- .sorted ()
73- .toList ();
66+ List <RankDoc > filteredDocs = Stream .of (combinedRankDocs ).filter (rd -> rd .score >= builder .getMinScore ()).sorted ().toList ();
7467
7568 assertEquals ("Filtered docs count" , 2 , filteredDocs .size ());
7669
7770 boolean foundDoc0 = false ;
7871 boolean foundDoc2 = false ;
7972 for (RankDoc scoreDoc : filteredDocs ) {
80- assertTrue ("Score should be >= minScore" , scoreDoc .score >= minScoreThreshold );
73+ assertTrue ("Score should be >= minScore" , scoreDoc .score >= minScoreThreshold );
8174 if (scoreDoc .doc == 0 ) {
82- assertEquals ("Doc 0 score" , 3.0f , scoreDoc .score , 0.001f );
75+ assertEquals ("Doc 0 score" , 3.0f , scoreDoc .score , 0.001f );
8376 foundDoc0 = true ;
8477 } else if (scoreDoc .doc == 2 ) {
85- assertEquals ("Doc 2 score" , 1.8f , scoreDoc .score , 0.001f );
78+ assertEquals ("Doc 2 score" , 1.8f , scoreDoc .score , 0.001f );
8679 foundDoc2 = true ;
8780 } else {
88- fail ("Unexpected document ID returned: " + scoreDoc .doc + " (should have been filtered)" );
81+ fail ("Unexpected document ID returned: " + scoreDoc .doc + " (should have been filtered)" );
8982 }
9083 }
9184 assertTrue ("Document 0 should have been found" , foundDoc0 );
9285 assertTrue ("Document 2 should have been found" , foundDoc2 );
9386 }
94- }
87+ }
0 commit comments