Fix OpenPIT with older versions

Author: luigidellaquila

x-pack/plugin/eql/qa/mixed-node/src/javaRestTest/java/org/elasticsearch/xpack/eql/qa/mixed_node/EqlSearchIT.java

@@ -294,7 +294,16 @@ private void assertSequncesQueryOnNodes(List<TestNode> nodesList) throws Excepti
             String filter = "{\"range\":{\"@timestamp\":{\"gte\":\"1970-05-01\"}}}";
 
             Request request = new Request("POST", index + "/_eql/search?" + filterPath);
-            request.setJsonEntity("{\"query\":\"" + query + "\",\"filter\":" + filter + "}");
+
+            StringBuilder payload = new StringBuilder("{\"query\":\"" + query + "\",\"filter\":" + filter);
+            if (randomBoolean()) {
+                payload.append(", \"allow_partial_search_results\": " + randomBoolean());
+            }
+            if (randomBoolean()) {
+                payload.append(", \"allow_partial_sequence_results\": " + randomBoolean());
+            }
+            payload.append("}");
+            request.setJsonEntity(payload.toString());
             assertBusy(() -> { assertResponse(expectedResponse, runEql(client, request)); });
         }
     }

x-pack/plugin/eql/src/main/java/org/elasticsearch/xpack/eql/execution/search/PITAwareQueryClient.java

@@ -7,12 +7,14 @@
 
 package org.elasticsearch.xpack.eql.execution.search;
 
+import org.elasticsearch.ElasticsearchStatusException;
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.action.search.ClosePointInTimeRequest;
 import org.elasticsearch.action.search.ClosePointInTimeResponse;
 import org.elasticsearch.action.search.MultiSearchRequest;
 import org.elasticsearch.action.search.MultiSearchResponse;
 import org.elasticsearch.action.search.OpenPointInTimeRequest;
+import org.elasticsearch.action.search.OpenPointInTimeResponse;
 import org.elasticsearch.action.search.SearchRequest;
 import org.elasticsearch.action.search.SearchResponse;
 import org.elasticsearch.action.search.TransportClosePointInTimeAction;
@@ -140,10 +142,33 @@ private <Response> void openPIT(ActionListener<Response> listener, Runnable runn
             .keepAlive(keepAlive)
             .allowPartialSearchResults(allowPartialSearchResults);
         request.indexFilter(filter);
-        client.execute(TransportOpenPointInTimeAction.TYPE, request, listener.delegateFailureAndWrap((l, r) -> {
-            pitId = r.getPointInTimeId();
-            runnable.run();
-        }));
+
+        client.execute(TransportOpenPointInTimeAction.TYPE, request, new ActionListener<>() {
+            @Override
+            public void onResponse(OpenPointInTimeResponse r) {
+                try {
+                    pitId = r.getPointInTimeId();
+                    runnable.run();
+                } catch (Exception e) {
+                    onFailure(e);
+                }
+            }
+
+            @Override
+            public void onFailure(Exception e) {
+                if (allowPartialSearchResults
+                    && e instanceof ElasticsearchStatusException
+                    && e.getMessage()
+                        .contains("The [allow_partial_search_results] parameter cannot be used while the cluster is still upgrading.")) {
+                    // This is for pre-8.16
+                    // We cannot use allow_partial_search_results during upgrades, so let's try without and hope to get no shard failures,
+                    // it's the best we can do, the query would fail anyway
+                    openPIT(listener, runnable, false);
+                } else {
+                    listener.onFailure(e);
+                }
+            }
+        });
     }
 
     @Override