Skip to content

Commit 295931a

Browse files
committed
Remove to-dos following code review
1 parent c4196a2 commit 295931a

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

x-pack/plugin/esql/src/main/generated/org/elasticsearch/xpack/esql/expression/function/scalar/ip/NetworkDirectionEvaluator.java

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/ip/NetworkDirection.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,6 @@ static BytesRef process(@Fixed(includeInToString=false, scope=THREAD_LOCAL) Byte
143143
boolean sourceInternal = false;
144144
boolean destinationInternal = false;
145145

146-
147-
// TODO: address scratch re-use due to .length issues above when sharing buffer
148146
for (int i = first; i < first + valueCount; i++) {
149147
if (NetworkDirectionUtils.inNetwork(sourceIpAddress, networks.getBytesRef(i, netScratch).utf8ToString())) {
150148
sourceInternal = true;

0 commit comments

Comments
 (0)