Skip to content

Commit 29cbbd9

Browse files
authored
Add more logging for IndexRecoveryIT#testSourceThrottling (#122830)
I couldn't reproduce the failure of the throttling time being zero on the recovery target node. Added more logging for the stats in case of failure. Resolve #122712
1 parent befc6a0 commit 29cbbd9

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

muted-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -318,9 +318,6 @@ tests:
318318
- class: org.elasticsearch.search.basic.SearchWithRandomDisconnectsIT
319319
method: testSearchWithRandomDisconnects
320320
issue: https://github.com/elastic/elasticsearch/issues/122707
321-
- class: org.elasticsearch.indices.recovery.IndexRecoveryIT
322-
method: testSourceThrottling
323-
issue: https://github.com/elastic/elasticsearch/issues/122712
324321
- class: org.elasticsearch.xpack.esql.action.EsqlActionBreakerIT
325322
issue: https://github.com/elastic/elasticsearch/issues/122810
326323
- class: org.elasticsearch.snapshots.DedicatedClusterSnapshotRestoreIT

server/src/internalClusterTest/java/org/elasticsearch/indices/recovery/IndexRecoveryIT.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,9 +342,17 @@ public void assertNodeHasThrottleTimeAndNoRecoveries(String nodeName, Boolean is
342342
assertThat(recoveryStats.currentAsSource(), equalTo(0));
343343
assertThat(recoveryStats.currentAsTarget(), equalTo(0));
344344
if (isRecoveryThrottlingNode) {
345-
assertThat("Throttling should be >0 for '" + nodeName + "'", recoveryStats.throttleTime().millis(), greaterThan(0L));
345+
assertThat(
346+
"Throttling should be >0 for '" + nodeName + "'. Node stats: " + nodesStatsResponse,
347+
recoveryStats.throttleTime().millis(),
348+
greaterThan(0L)
349+
);
346350
} else {
347-
assertThat("Throttling should be =0 for '" + nodeName + "'", recoveryStats.throttleTime().millis(), equalTo(0L));
351+
assertThat(
352+
"Throttling should be =0 for '" + nodeName + "'. Node stats: " + nodesStatsResponse,
353+
recoveryStats.throttleTime().millis(),
354+
equalTo(0L)
355+
);
348356
}
349357
}
350358

0 commit comments

Comments
 (0)