Skip to content

Commit 2a86978

Browse files
author
Max Hniebergall
committed
Fix tests
1 parent 565a5e2 commit 2a86978

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/http/sender/HttpRequestSenderTests.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
package org.elasticsearch.xpack.inference.external.http.sender;
99

1010
import org.apache.http.HttpHeaders;
11+
import org.elasticsearch.ElasticsearchStatusException;
1112
import org.elasticsearch.ElasticsearchTimeoutException;
1213
import org.elasticsearch.action.support.PlainActionFuture;
1314
import org.elasticsearch.common.settings.Settings;
@@ -162,12 +163,13 @@ public void testHttpRequestSender_Throws_WhenATimeoutOccurs() throws Exception {
162163
PlainActionFuture<InferenceServiceResults> listener = new PlainActionFuture<>();
163164
sender.send(RequestManagerTests.createMock(), new DocumentsOnlyInput(List.of()), TimeValue.timeValueNanos(1), listener);
164165

165-
var thrownException = expectThrows(ElasticsearchTimeoutException.class, () -> listener.actionGet(TIMEOUT));
166+
var thrownException = expectThrows(ElasticsearchStatusException.class, () -> listener.actionGet(TIMEOUT));
166167

167168
assertThat(
168169
thrownException.getMessage(),
169170
is(format("Request timed out waiting to be sent after [%s]", TimeValue.timeValueNanos(1)))
170171
);
172+
assertThat(thrownException.status().getStatus(), is(408));
171173
}
172174
}
173175

@@ -187,12 +189,13 @@ public void testHttpRequestSenderWithTimeout_Throws_WhenATimeoutOccurs() throws
187189
PlainActionFuture<InferenceServiceResults> listener = new PlainActionFuture<>();
188190
sender.send(RequestManagerTests.createMock(), new DocumentsOnlyInput(List.of()), TimeValue.timeValueNanos(1), listener);
189191

190-
var thrownException = expectThrows(ElasticsearchTimeoutException.class, () -> listener.actionGet(TIMEOUT));
192+
var thrownException = expectThrows(ElasticsearchStatusException.class, () -> listener.actionGet(TIMEOUT));
191193

192194
assertThat(
193195
thrownException.getMessage(),
194196
is(format("Request timed out waiting to be sent after [%s]", TimeValue.timeValueNanos(1)))
195197
);
198+
assertThat(thrownException.status().getStatus(), is(408));
196199
}
197200
}
198201

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/http/sender/RequestExecutorServiceTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
package org.elasticsearch.xpack.inference.external.http.sender;
99

1010
import org.elasticsearch.ElasticsearchException;
11+
import org.elasticsearch.ElasticsearchStatusException;
1112
import org.elasticsearch.ElasticsearchTimeoutException;
1213
import org.elasticsearch.action.ActionListener;
1314
import org.elasticsearch.action.support.PlainActionFuture;
@@ -238,12 +239,13 @@ public void testExecute_CallsOnFailure_WhenRequestTimesOut() {
238239
var listener = new PlainActionFuture<InferenceServiceResults>();
239240
service.execute(RequestManagerTests.createMock(), new DocumentsOnlyInput(List.of()), TimeValue.timeValueNanos(1), listener);
240241

241-
var thrownException = expectThrows(ElasticsearchTimeoutException.class, () -> listener.actionGet(TIMEOUT));
242+
var thrownException = expectThrows(ElasticsearchStatusException.class, () -> listener.actionGet(TIMEOUT));
242243

243244
assertThat(
244245
thrownException.getMessage(),
245246
is(format("Request timed out waiting to be sent after [%s]", TimeValue.timeValueNanos(1)))
246247
);
248+
assertThat(thrownException.status().getStatus(), is(408));
247249
}
248250

249251
public void testExecute_PreservesThreadContext() throws InterruptedException, ExecutionException, TimeoutException {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/http/sender/RequestTaskTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
package org.elasticsearch.xpack.inference.external.http.sender;
99

10-
import org.elasticsearch.ElasticsearchTimeoutException;
10+
import org.elasticsearch.ElasticsearchStatusException;
1111
import org.elasticsearch.action.ActionListener;
1212
import org.elasticsearch.action.support.PlainActionFuture;
1313
import org.elasticsearch.core.TimeValue;
@@ -86,13 +86,14 @@ public void testRequest_ReturnsTimeoutException() {
8686
listener
8787
);
8888

89-
var thrownException = expectThrows(ElasticsearchTimeoutException.class, () -> listener.actionGet(TIMEOUT));
89+
var thrownException = expectThrows(ElasticsearchStatusException.class, () -> listener.actionGet(TIMEOUT));
9090
assertThat(
9191
thrownException.getMessage(),
9292
is(format("Request timed out waiting to be sent after [%s]", TimeValue.timeValueMillis(1)))
9393
);
9494
assertTrue(requestTask.hasCompleted());
9595
assertTrue(requestTask.getRequestCompletedFunction().get());
96+
assertThat(thrownException.status().getStatus(), is(408));
9697
}
9798

9899
public void testRequest_DoesNotCallOnFailureTwiceWhenTimingOut() throws Exception {

0 commit comments

Comments
 (0)