Got pinnedretriever yaml to working state without cluster

Author: mridula-s109

x-pack/plugin/search-business-rules/build.gradle

@@ -15,5 +15,38 @@ base {
 dependencies {
   compileOnly project(path: xpackModule('core'))
   testImplementation(testArtifact(project(xpackModule('core'))))
-  testImplementation project(":test:framework")
+  testImplementation(testArtifact(project(':server')))
+
+  clusterModules project(':modules:mapper-extras')
+  clusterModules project(xpackModule('search-business-rules'))
+  clusterModules project(':modules:lang-painless')
+}
+
+restResources {
+  restApi {
+    include '_common',
+            'bulk',
+            'cluster',
+            'indices',
+            'index',
+            'search',
+            'xpack'
+  }
+  restTests {
+    includeXpack 'searchbusinessrules'
+  }
+}
+
+tasks.named("yamlRestTest") {
+  usesDefaultDistribution("uses search business rules plugin")
+}
+
+artifacts {
+  restXpackTests(new File(projectDir, "src/yamlRestTest/resources/rest-api-spec/test"))
+}
+
+testClusters.configureEach {
+  testDistribution = 'DEFAULT'
+  setting 'xpack.license.self_generated.type', 'trial'
+  setting 'xpack.security.enabled', 'false'
 }

x-pack/plugin/search-business-rules/src/main/resources/META-INF/services/org.elasticsearch.features.FeatureSpecification

@@ -49,11 +49,11 @@ setup:
   - match: { hits.hits.2._id: doc3 }
   - match: { hits.hits.3._id: doc4 }
   - match: { hits.hits.4._id: doc5 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score > 1.0 }
-  - is_true: { hits.hits.2._score <= 1.0 }
-  - is_true: { hits.hits.3._score <= 1.0 }
-  - is_true: { hits.hits.4._score <= 1.0 }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score > 1.0
+  - is_true: hits.hits.2._score <= 1.0
+  - is_true: hits.hits.3._score <= 1.0
+  - is_true: hits.hits.4._score <= 1.0
 
 ---
 "pinned retriever parameter variations":
@@ -76,11 +76,11 @@ setup:
   - match: { hits.total.value: 5 }
   - match: { hits.hits.0._id: doc1 }
   - match: { hits.hits.1._id: doc2 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score > 1.0 }
-  - is_true: { hits.hits.2._score <= 1.0 }
-  - is_true: { hits.hits.3._score <= 1.0 }
-  - is_true: { hits.hits.4._score <= 1.0 }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score > 1.0
+  - is_true: hits.hits.2._score <= 1.0
+  - is_true: hits.hits.3._score <= 1.0
+  - is_true: hits.hits.4._score <= 1.0
 
   - do:
       search:
@@ -96,11 +96,11 @@ setup:
 
   - match: { hits.total.value: 5 }
   - match: { hits.hits.0._id: doc1 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score <= 1.0 }
-  - is_true: { hits.hits.2._score <= 1.0 }
-  - is_true: { hits.hits.3._score <= 1.0 }
-  - is_true: { hits.hits.4._score <= 1.0 }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score <= 1.0
+  - is_true: hits.hits.2._score <= 1.0
+  - is_true: hits.hits.3._score <= 1.0
+  - is_true: hits.hits.4._score <= 1.0
 
   - do:
       search:
@@ -118,11 +118,11 @@ setup:
 
   - match: { hits.total.value: 5 }
   - match: { hits.hits.0._id: doc1 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score <= 1.0 }
-  - is_true: { hits.hits.2._score <= 1.0 }
-  - is_true: { hits.hits.3._score <= 1.0 }
-  - is_true: { hits.hits.4._score <= 1.0 }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score <= 1.0
+  - is_true: hits.hits.2._score <= 1.0
+  - is_true: hits.hits.3._score <= 1.0
+  - is_true: hits.hits.4._score <= 1.0
 
 ---
 "pinned retriever with combined parameters":
@@ -144,11 +144,11 @@ setup:
   - match: { hits.total.value: 5 }
   - match: { hits.hits.0._id: doc1 }
   - match: { hits.hits.1._id: doc2 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score > 1.0 }
-  - is_true: { hits.hits.2._score <= 1.0 }
-  - is_true: { hits.hits.3._score <= 1.0 }
-  - is_true: { hits.hits.4._score <= 1.0 }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score > 1.0
+  - is_true: hits.hits.2._score <= 1.0
+  - is_true: hits.hits.3._score <= 1.0
+  - is_true: hits.hits.4._score <= 1.0
 
   - do:
       search:
@@ -172,11 +172,11 @@ setup:
   - match: { hits.hits.1._id: doc3 }
   - match: { hits.hits.2._id: doc2 }
   - match: { hits.hits.3._id: doc4 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score > 1.0 }
-  - is_true: { hits.hits.2._score > 1.0 }
-  - is_true: { hits.hits.3._score > 1.0 }
-  - is_true: { hits.hits.4._score <= 1.0 }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score > 1.0
+  - is_true: hits.hits.2._score > 1.0
+  - is_true: hits.hits.3._score > 1.0
+  - is_true: hits.hits.4._score <= 1.0
 
 ---
 "pinned retriever combined with rrf":
@@ -213,10 +213,10 @@ setup:
   - match: { hits.total.value: 5 }
   - match: { hits.hits.0._id: doc1 }
   - match: { hits.hits.1._id: doc2 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score > 1.0 }
-  - is_true: { hits.hits.2._score > hits.hits.3._score }
-  - is_true: { hits.hits.3._score > hits.hits.4._score }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score > 1.0
+  - is_true: hits.hits.2._score > hits.hits.3._score
+  - is_true: hits.hits.3._score > hits.hits.4._score
 
 ---
 "pinned retriever with pagination":
@@ -237,7 +237,7 @@ setup:
   - match: { hits.total.value: 5 }
   - length: { hits.hits: 1 }
   - match: { hits.hits.0._id: doc2 }
-  - is_true: { hits.hits.0._score > 1.0 }
+  - is_true: hits.hits.0._score > 1.0
 
 ---
 "pinned retriever as a sub-retriever":
@@ -270,11 +270,11 @@ setup:
               ]
 
   - match: { hits.total.value: 5 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score > 1.0 }
-  - is_true: { hits.hits.2._score <= 1.0 }
-  - is_true: { hits.hits.3._score <= 1.0 }
-  - is_true: { hits.hits.4._score <= 1.0 }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score > 1.0
+  - is_true: hits.hits.2._score <= 1.0
+  - is_true: hits.hits.3._score <= 1.0
+  - is_true: hits.hits.4._score <= 1.0
 
 ---
 "pinned retriever with explicit sort on score":
@@ -294,11 +294,11 @@ setup:
   - match: { hits.total.value: 5 }
   - match: { hits.hits.0._id: doc1 }
   - match: { hits.hits.1._id: doc2 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score > 1.0 }
-  - is_true: { hits.hits.2._score <= 1.0 }
-  - is_true: { hits.hits.3._score <= 1.0 }
-  - is_true: { hits.hits.4._score <= 1.0 }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score > 1.0
+  - is_true: hits.hits.2._score <= 1.0
+  - is_true: hits.hits.3._score <= 1.0
+  - is_true: hits.hits.4._score <= 1.0
 
 ---
 "pinned retriever with rank window size":
@@ -323,7 +323,7 @@ setup:
   - match: { hits.total.value: 5 }
   - length: { hits.hits: 1 }
   - match: { hits.hits.0._id: doc1 }
-  - is_true: { hits.hits.0._score > 1.0 }
+  - is_true: hits.hits.0._score > 1.0
 
   - do:
       headers:
@@ -344,17 +344,15 @@ setup:
   - length: { hits.hits: 5 }
   - match: { hits.hits.0._id: doc1 }
   - match: { hits.hits.1._id: doc2 }
-  - is_true: { hits.hits.0._score > 1.0 }
-  - is_true: { hits.hits.1._score > 1.0 }
-  - is_true: { hits.hits.2._score <= 1.0 }
-  - is_true: { hits.hits.3._score <= 1.0 }
-  - is_true: { hits.hits.4._score <= 1.0 }
+  - is_true: hits.hits.0._score > 1.0
+  - is_true: hits.hits.1._score > 1.0
+  - is_true: hits.hits.2._score <= 1.0
+  - is_true: hits.hits.3._score <= 1.0
+  - is_true: hits.hits.4._score <= 1.0
 
 ---
 "pinned retriever explanation":
   - do:
-      headers:
-        Content-Type: application/json
       search:
         index: test-index1
         body:
@@ -368,16 +366,16 @@ setup:
           explain: true
 
   - match: { hits.hits.0._id: doc1 }
-  - is_true: { hits.hits.0._explanation.value > 1.0 }
-  - is_true: { hits.hits.0._explanation.description: "pinned documents" }
-  - is_true: { hits.hits.0._explanation.details.0.details.0.details.0.description: "pinned_by: [ids]" }
-  - is_true: { hits.hits.0._explanation.details.0.details.0.details.1.description: "is_pinned: true" }
+  - is_true: hits.hits.0._explanation.value > 1.0
+  - match: { hits.hits.0._explanation.description: "pinned documents" }
+  - match: { hits.hits.0._explanation.details.0.details.0.details.0.description: "pinned_by: [ids]" }
+  - match: { hits.hits.0._explanation.details.0.details.0.details.1.description: "is_pinned: true" }
 
   - match: { hits.hits.1._id: doc2 }
-  - is_true: { hits.hits.1._explanation.value > 1.0 }
-  - is_true: { hits.hits.1._explanation.description: "pinned documents" }
-  - is_true: { hits.hits.1._explanation.details.0.details.0.details.0.description: "pinned_by: [ids]" }
-  - is_true: { hits.hits.1._explanation.details.0.details.0.details.1.description: "is_pinned: true" }
+  - is_true: hits.hits.1._explanation.value > 1.0
+  - match: { hits.hits.1._explanation.description: "pinned documents" }
+  - match: { hits.hits.1._explanation.details.0.details.0.details.0.description: "pinned_by: [ids]" }
+  - match: { hits.hits.1._explanation.details.0.details.0.details.1.description: "is_pinned: true" }
 
 ---
 "pinned retriever with empty parameters":
@@ -415,14 +413,16 @@ setup:
                     match_all: {}
 
   - do:
-      catch: /\[pinned\] Max of 100 ids exceeded: 101 provided./
+      catch: /\[pinned\] Cannot specify both ids and docs parameters/
       search:
         index: test-index1
         body:
           retriever:
             pinned:
-              ids: ["doc1"] * 101
+              ids: ["doc1", "doc3"]
+              docs: []
               retriever:
                 standard:
                   query:
-                    match_all: {} 
+                    match_all: {}
+