Skip to content

Commit 2b0ab5b

Browse files
committed
More fix up merge
1 parent e13ac02 commit 2b0ab5b

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

modules/repository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobStoreContainerTests.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import software.amazon.awssdk.services.s3.model.CompleteMultipartUploadRequest;
2121
import software.amazon.awssdk.services.s3.model.CompleteMultipartUploadResponse;
2222
import software.amazon.awssdk.services.s3.model.CompletedPart;
23+
import software.amazon.awssdk.services.s3.model.CopyObjectRequest;
24+
import software.amazon.awssdk.services.s3.model.CopyObjectResponse;
2325
import software.amazon.awssdk.services.s3.model.CreateMultipartUploadRequest;
2426
import software.amazon.awssdk.services.s3.model.CreateMultipartUploadResponse;
2527
import software.amazon.awssdk.services.s3.model.ObjectCannedACL;
@@ -459,7 +461,7 @@ public void testCopy() throws Exception {
459461
final var blobName = randomAlphaOfLengthBetween(1, 10);
460462

461463
final StorageClass storageClass = randomFrom(StorageClass.values());
462-
final CannedAccessControlList cannedAccessControlList = randomBoolean() ? randomFrom(CannedAccessControlList.values()) : null;
464+
final ObjectCannedACL cannedAccessControlList = randomBoolean() ? randomFrom(ObjectCannedACL.values()) : null;
463465

464466
final var blobStore = mock(S3BlobStore.class);
465467
when(blobStore.bucket()).thenReturn(sourceBucketName);
@@ -478,17 +480,17 @@ public void testCopy() throws Exception {
478480
final var client = configureMockClient(blobStore);
479481

480482
final ArgumentCaptor<CopyObjectRequest> captor = ArgumentCaptor.forClass(CopyObjectRequest.class);
481-
when(client.copyObject(captor.capture())).thenReturn(new CopyObjectResult());
483+
when(client.copyObject(captor.capture())).thenReturn(CopyObjectResponse.builder().build());
482484

483485
destinationBlobContainer.copyBlob(randomPurpose(), sourceBlobContainer, sourceBlobName, blobName, randomLongBetween(1, 10_000));
484486

485487
final CopyObjectRequest request = captor.getValue();
486-
assertEquals(sourceBucketName, request.getSourceBucketName());
487-
assertEquals(sourceBlobPath.buildAsString() + sourceBlobName, request.getSourceKey());
488-
assertEquals(sourceBucketName, request.getDestinationBucketName());
489-
assertEquals(destinationBlobPath.buildAsString() + blobName, request.getDestinationKey());
490-
assertEquals(storageClass.toString(), request.getStorageClass());
491-
assertEquals(cannedAccessControlList, request.getCannedAccessControlList());
488+
assertEquals(sourceBucketName, request.sourceBucket());
489+
assertEquals(sourceBlobPath.buildAsString() + sourceBlobName, request.sourceKey());
490+
assertEquals(sourceBucketName, request.destinationBucket());
491+
assertEquals(destinationBlobPath.buildAsString() + blobName, request.destinationKey());
492+
assertEquals(storageClass, request.storageClass());
493+
assertEquals(cannedAccessControlList, request.acl());
492494

493495
closeMockClient(blobStore);
494496
}

0 commit comments

Comments
 (0)