Skip to content

Commit 2b92a4a

Browse files
authored
SQL: Unmute TO_CHAR test and remove currently failing cases (#138430)
Fixes #120575 Fixes #126213 Fixes #126494 Unmute `DateTimeToCharProcessorTests`, and remove some of the failing test cases.
1 parent 2af4cb8 commit 2b92a4a

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

muted-tests.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ tests:
6060
- class: org.elasticsearch.xpack.ccr.FollowIndexSecurityIT
6161
method: testCleanShardFollowTaskAfterDeleteFollower
6262
issue: https://github.com/elastic/elasticsearch/issues/120339
63-
- class: org.elasticsearch.xpack.sql.expression.function.scalar.datetime.DateTimeToCharProcessorTests
64-
issue: https://github.com/elastic/elasticsearch/issues/120575
6563
- class: org.elasticsearch.xpack.security.authc.service.ServiceAccountIT
6664
method: testAuthenticateShouldNotFallThroughInCaseOfFailure
6765
issue: https://github.com/elastic/elasticsearch/issues/120902

x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/expression/function/scalar/datetime/DateTimeToCharProcessorTests.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,15 @@
3333
/**
3434
* Tests the {@link ToCharFormatter} against actual PostgreSQL output.
3535
*
36+
* <p>
37+
* Note: Recreating the data set has some complexities,
38+
* as modern Postgres versions (+12) don't have some of the configured timezones,
39+
* and they also may generate different results for dates before 1900.
40+
* </p>
41+
* <p>
42+
* Consider if it's worth changing the dataset for this test.
43+
* </p>
44+
*
3645
* Process to (re)generate the test data:
3746
* <ol>
3847
* <li>Run the @{link {@link ToCharTestScript#main(String[])}} class</li>

0 commit comments

Comments
 (0)