bugfix

Author: julian-elastic

docs/changelog/132889.yaml

@@ -1,6 +1,6 @@
 pr: 132889
 summary: Improve Expanding Lookup Join performance by pushing a filter to the lookup
   join
-area: "ES|QL, Performance"
+area: "ES|QL"
 type: enhancement
-issues: []
+issues: [ ]

x-pack/plugin/esql/qa/testFixtures/src/main/resources/lookup-join.csv-spec

@@ -5331,9 +5331,6 @@ lookupJoinWithExpressionOfOtherFields
   | KEEP id_int, name_str, extra1, other1, other2
   | SORT id_int, name_str, extra1, other1, other2
   | LIMIT 20
-  /*
-      NEED TO DEBUG WHY THE FILTER IS NOT PUSHED TO THE RIGHT SIDE OF THE LOOKUP JOIN
-   */
   ;
 
 warning:Line 2:3: evaluation of [LOOKUP JOIN multi_column_joinable_lookup ON id_int, is_active_bool] failed, treating result as null. Only first 20 failures recorded.

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/enrich/ExpressionQueryList.java

@@ -64,7 +64,8 @@ private void buildPrePostJoinFilter(PhysicalPlan rightPreJoinPlan, ClusterServic
                 );
                 // If the pre-join filter is a FilterExec, we can convert it to a QueryBuilder
                 // try to convert it to a QueryBuilder, if not possible apply it after the join
-                if (filterExec instanceof TranslationAware translationAware) {
+                if (filterExec.condition() instanceof TranslationAware translationAware
+                    && TranslationAware.Translatable.YES.equals(translationAware.translatable(lucenePushdownPredicates))) {
                     preJoinFilters.add(
                         translationAware.asQuery(lucenePushdownPredicates, TRANSLATOR_HANDLER).toQueryBuilder().toQuery(context)
                     );