Skip to content

Commit 2eebbb4

Browse files
authored
ESQL: Rename evaluators for FIRST and LAST (#132466)
I'm going to be reusing the evaluators from FIRST_OVER_TIME and LAST_OVER_TIME for FIRST and LAST. This renames the evaluators themselves to indicate that they are the actual evaluators for FIRST and LAST. Relates to #108385
1 parent fb3caa7 commit 2eebbb4

File tree

32 files changed

+396
-410
lines changed

32 files changed

+396
-410
lines changed

x-pack/plugin/esql/compute/build.gradle

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -900,28 +900,28 @@ tasks.named('stringTemplates').configure {
900900
}
901901

902902
// TODO: add {value}_over_time for other types: boolean, bytes_refs
903-
File valueOverTimeAggregatorInputFile = file("src/main/java/org/elasticsearch/compute/aggregation/X-ValueOverTimeAggregator.java.st")
903+
File valueByTimestampAggregatorInputFile = file("src/main/java/org/elasticsearch/compute/aggregation/X-ValueByTimestampAggregator.java.st")
904904
["First", "Last"].forEach { Occurrence ->
905905
{
906906
template {
907907
it.properties = addOccurrence(intProperties, Occurrence)
908-
it.inputFile = valueOverTimeAggregatorInputFile
909-
it.outputFile = "org/elasticsearch/compute/aggregation/${Occurrence}OverTimeIntAggregator.java"
908+
it.inputFile = valueByTimestampAggregatorInputFile
909+
it.outputFile = "org/elasticsearch/compute/aggregation/${Occurrence}IntByTimestampAggregator.java"
910910
}
911911
template {
912912
it.properties = addOccurrence(longProperties, Occurrence)
913-
it.inputFile = valueOverTimeAggregatorInputFile
914-
it.outputFile = "org/elasticsearch/compute/aggregation/${Occurrence}OverTimeLongAggregator.java"
913+
it.inputFile = valueByTimestampAggregatorInputFile
914+
it.outputFile = "org/elasticsearch/compute/aggregation/${Occurrence}LongByTimestampAggregator.java"
915915
}
916916
template {
917917
it.properties = addOccurrence(floatProperties, Occurrence)
918-
it.inputFile = valueOverTimeAggregatorInputFile
919-
it.outputFile = "org/elasticsearch/compute/aggregation/${Occurrence}OverTimeFloatAggregator.java"
918+
it.inputFile = valueByTimestampAggregatorInputFile
919+
it.outputFile = "org/elasticsearch/compute/aggregation/${Occurrence}FloatByTimestampAggregator.java"
920920
}
921921
template {
922922
it.properties = addOccurrence(doubleProperties, Occurrence)
923-
it.inputFile = valueOverTimeAggregatorInputFile
924-
it.outputFile = "org/elasticsearch/compute/aggregation/${Occurrence}OverTimeDoubleAggregator.java"
923+
it.inputFile = valueByTimestampAggregatorInputFile
924+
it.outputFile = "org/elasticsearch/compute/aggregation/${Occurrence}DoubleByTimestampAggregator.java"
925925
}
926926
}
927927
}
Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/FirstDoubleByTimestampAggregatorFunctionSupplier.java

Lines changed: 46 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)