polish code

Author: jan-elastic

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/SampleBooleanAggregator.java

@@ -26,6 +26,7 @@ import org.elasticsearch.core.Releasables;
 import org.elasticsearch.search.sort.SortOrder;
 
 import java.util.SplittableRandom;
+import java.util.random.RandomGenerator;
 
 /**
  * Sample N field values for $type$.
@@ -119,18 +120,21 @@ class Sample$Type$Aggregator {
     public static class GroupingState implements GroupingAggregatorState {
         private final CircuitBreaker breaker;
         private final BytesRefBucketedSort sort;
+        private final BreakingBytesRefBuilder bytesRefBuilder;
+        private final RandomGenerator random;
 
         private GroupingState(BigArrays bigArrays, int limit) {
             this.breaker = bigArrays.breakerService().getBreaker(CircuitBreaker.REQUEST);
             this.sort = new BytesRefBucketedSort(breaker, "sample", bigArrays, SortOrder.ASC, limit);
+            this.bytesRefBuilder = new BreakingBytesRefBuilder(breaker, "sample");
+            this.random = new SplittableRandom();
         }
 
         public void add(int groupId, $type$ value) {
-            try (BreakingBytesRefBuilder builder = new BreakingBytesRefBuilder(breaker, "sample")) {
-                ENCODER.encodeLong(new SplittableRandom().nextLong(), builder);
-                ENCODER.encode$Type$(value, builder);
-                sort.collect(builder.bytesRefView(), groupId);
-            }
+            ENCODER.encodeLong(random.nextLong(), bytesRefBuilder);
+            ENCODER.encode$Type$(value, bytesRefBuilder);
+            sort.collect(bytesRefBuilder.bytesRefView(), groupId);
+            bytesRefBuilder.clear();
         }
 
         public void merge(int groupId, GroupingState other, int otherGroupId) {
@@ -153,7 +157,7 @@ class Sample$Type$Aggregator {
 
         @Override
         public void close() {
-            Releasables.closeExpectNoException(sort);
+            Releasables.closeExpectNoException(sort, bytesRefBuilder);
         }
     }
 

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/SampleBytesRefAggregator.java

@@ -56,7 +56,8 @@ public static Iterable<Object[]> parameters() {
                 MultiRowTestCaseSupplier.cartesianPointCases(1, 1000, MultiRowTestCaseSupplier.IncludingAltitude.NO),
                 MultiRowTestCaseSupplier.geoShapeCasesWithoutCircle(1, 100, MultiRowTestCaseSupplier.IncludingAltitude.NO),
                 MultiRowTestCaseSupplier.cartesianShapeCasesWithoutCircle(1, 100, MultiRowTestCaseSupplier.IncludingAltitude.NO)
-            ).flatMap(List::stream)
+            )
+                .flatMap(List::stream)
                 .map(fieldCaseSupplier -> makeSupplier(fieldCaseSupplier, limitCaseSupplier))
                 .collect(Collectors.toCollection(() -> suppliers));
         }
@@ -68,8 +69,10 @@ protected Expression build(Source source, List<Expression> args) {
         return new Sample(source, args.get(0), args.get(1));
     }
 
-    private static TestCaseSupplier makeSupplier(TestCaseSupplier.TypedDataSupplier fieldSupplier, TestCaseSupplier.TypedDataSupplier limitCaseSupplier
-        ) {
+    private static TestCaseSupplier makeSupplier(
+        TestCaseSupplier.TypedDataSupplier fieldSupplier,
+        TestCaseSupplier.TypedDataSupplier limitCaseSupplier
+    ) {
         return new TestCaseSupplier(fieldSupplier.name(), List.of(fieldSupplier.type(), limitCaseSupplier.type()), () -> {
             var fieldTypedData = fieldSupplier.get();
             var limitTypedData = limitCaseSupplier.get().forceLiteral();