tests to demonstrate the bug

Author: not-napoleon

x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries.csv-spec

@@ -559,3 +559,22 @@ cnt:long | cluster:keyword | pod:keyword
 1        | prod            | two
 1        | prod            | three
 ;
+
+Max of Rate with Bucket
+TS k8s
+| STATS maxRate = max(rate(network.total_cost))  BY tbucket = bucket(@timestamp, 1hour) 
+;
+
+maxRate:double | tbucket:datetime
+0.058979885057471274 | 2024-05-10T00:00:00.000Z
+;
+
+Max of Rate with Bucket, Rename Timestamp
+TS k8s
+| RENAME `@timestamp` AS newTs
+| STATS maxRate = max(rate(network.total_cost))  BY tbucket = bucket(newTs, 1hour) 
+;
+
+maxRate:double | tbucket:datetime
+0.058979885057471274 | 2024-05-10T00:00:00.000Z
+;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/AddTimeSeriesFields.java

@@ -0,0 +1,26 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+package org.elasticsearch.xpack.esql.analysis;
+
+import org.elasticsearch.index.IndexMode;
+import org.elasticsearch.xpack.esql.plan.logical.EsRelation;
+import org.elasticsearch.xpack.esql.plan.logical.LogicalPlan;
+import org.elasticsearch.xpack.esql.rule.Rule;
+
+public class AddTimeSeriesFields extends Rule<LogicalPlan, LogicalPlan> {
+    @Override
+    public LogicalPlan apply(LogicalPlan logicalPlan) {
+        /*
+        return logicalPlan.transformUp(p -> p instanceof EsRelation r && r.indexMode()== IndexMode.TIME_SERIES, relation -> {
+
+        });
+
+         */
+        return logicalPlan;
+    }
+}

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/rules/logical/TranslateTimeSeriesAggregateTests.java

@@ -79,7 +79,7 @@ protected LogicalPlan planK8s(String query) {
      * }</pre>
      */
     public void testMaxOverTime() {
-        assumeTrue("requires metrics command", EsqlCapabilities.Cap.METRICS_COMMAND.isEnabled());
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.TS_COMMAND_V0.isEnabled());
         LogicalPlan plan = planK8s("""
             TS k8s
             | STATS count(max_over_time(network.cost)) BY time_bucket = BUCKET(@timestamp, 1 minute)
@@ -94,7 +94,7 @@ public void testMaxOverTime() {
     }
 
     public void testMaxOfRate() {
-        assumeTrue("requires metrics command", EsqlCapabilities.Cap.METRICS_COMMAND.isEnabled());
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.TS_COMMAND_V0.isEnabled());
         LogicalPlan plan = planK8s("""
             TS k8s
             | STATS max(rate(network.total_bytes_in)) BY time_bucket = BUCKET(@timestamp, 1 minute)
@@ -126,7 +126,7 @@ public void testMaxOfRate() {
      * }</pre>
      */
     public void testAvgOfAvgOverTime() {
-        assumeTrue("requires metrics command", EsqlCapabilities.Cap.METRICS_COMMAND.isEnabled());
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.TS_COMMAND_V0.isEnabled());
         LogicalPlan plan = planK8s("""
             TS k8s
             | STATS avg_cost=avg(avg_over_time(network.cost)) BY cluster, time_bucket = bucket(@timestamp,1minute)
@@ -142,4 +142,31 @@ public void testAvgOfAvgOverTime() {
         Eval bucketEval = as(innerStats.child(), Eval.class); // compute the tbucket
         EsRelation relation = as(bucketEval.child(), EsRelation.class);
     }
+
+    public void testRenameTimestampWithRate() {
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.TS_COMMAND_V0.isEnabled());
+        LogicalPlan plan = planK8s("""
+            TS k8s
+            | RENAME `@timestamp` AS newTs
+            | STATS maxRate = max(rate(network.total_cost))  BY tbucket = bucket(newTs, 1hour)
+            """);
+    }
+
+    public void testRenameTimestampWithOverTimeFunction() {
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.TS_COMMAND_V0.isEnabled());
+        LogicalPlan plan = planK8s("""
+            TS k8s
+            | RENAME `@timestamp` AS newTs
+            | STATS maxRate = max(max_over_time(network.eth0.tx))  BY tbucket = bucket(newTs, 1hour)
+            """);
+    }
+
+    public void testRenameTimestampWithOverTimeFunctionWithTbucket() {
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.TS_COMMAND_V0.isEnabled());
+        LogicalPlan plan = planK8s("""
+            TS k8s
+            | RENAME `@timestamp` AS newTs
+            | STATS maxRate = max(max_over_time(network.eth0.tx))  BY tbucket = tbucket(1hour)
+            """);
+    }
 }