Fix a few toString implementations+usages that affect test performance (#112380)

No need to precompute the toString for `ActionListener` and
`Releasable`, that's quite expensive at times. Also string concat is way
faster than formating these days, so use that in the transport channels.
Lastly, short-circuit some obvious spots in network address
serialization and remove code that duplicates the JDK (remove the IPV4
specific forbidden API because it makes no sense, but still needed to
disable the check to make the build green because of the exclude on the
parent class).

Author: original-brownbear

libs/core/src/main/java/org/elasticsearch/core/Releasables.java

@@ -149,8 +149,9 @@ public static Releasable assertOnce(final Releasable delegate) {
                 private final AtomicReference<Exception> firstCompletion = new AtomicReference<>();
 
                 private void assertFirstRun() {
-                    var previousRun = firstCompletion.compareAndExchange(null, new Exception(delegate.toString()));
-                    assert previousRun == null : previousRun; // reports the stack traces of both completions
+                    var previousRun = firstCompletion.compareAndExchange(null, new Exception("already executed"));
+                    // reports the stack traces of both completions
+                    assert previousRun == null : new AssertionError(delegate.toString(), previousRun);
                 }
 
                 @Override

libs/core/src/test/java/org/elasticsearch/core/ReleasablesTests.java

@@ -69,7 +69,7 @@ public String toString() {
                 .anyMatch(ste -> ste.toString().contains("CloserWithIdentifiableMethodNames.closeMethod2"))
         );
         assertTrue(
-            Arrays.stream(assertionError.getCause().getStackTrace())
+            Arrays.stream(assertionError.getCause().getCause().getStackTrace())
                 .anyMatch(ste -> ste.toString().contains("CloserWithIdentifiableMethodNames.closeMethod1"))
         );
     }

server/src/main/java/org/elasticsearch/action/ActionListener.java

@@ -388,8 +388,8 @@ static <Response> ActionListener<Response> assertOnce(ActionListener<Response> d
                 private final AtomicReference<ElasticsearchException> firstCompletion = new AtomicReference<>();
 
                 private void assertFirstRun() {
-                    var previousRun = firstCompletion.compareAndExchange(null, new ElasticsearchException(delegate.toString()));
-                    assert previousRun == null : previousRun; // reports the stack traces of both completions
+                    var previousRun = firstCompletion.compareAndExchange(null, new ElasticsearchException("executed already"));
+                    assert previousRun == null : "[" + delegate + "] " + previousRun; // reports the stack traces of both completions
                 }
 
                 @Override

server/src/main/java/org/elasticsearch/common/network/InetAddresses.java

@@ -17,6 +17,7 @@
 
 package org.elasticsearch.common.network;
 
+import org.elasticsearch.core.SuppressForbidden;
 import org.elasticsearch.core.Tuple;
 
 import java.net.Inet4Address;
@@ -246,14 +247,14 @@ public static String toUriString(InetAddress ip) {
      * @return {@code String} containing the text-formatted IP address
      * @since 10.0
      */
+    @SuppressForbidden(reason = "java.net.Inet4Address#getHostAddress() is fine no need to duplicate its code")
     public static String toAddrString(InetAddress ip) {
         if (ip == null) {
             throw new NullPointerException("ip");
         }
-        if (ip instanceof Inet4Address) {
+        if (ip instanceof Inet4Address inet4Address) {
             // For IPv4, Java's formatting is good enough.
-            byte[] bytes = ip.getAddress();
-            return (bytes[0] & 0xff) + "." + (bytes[1] & 0xff) + "." + (bytes[2] & 0xff) + "." + (bytes[3] & 0xff);
+            return inet4Address.getHostAddress();
         }
         if ((ip instanceof Inet6Address) == false) {
             throw new IllegalArgumentException("ip");

server/src/main/java/org/elasticsearch/common/network/NetworkAddress.java

@@ -57,7 +57,7 @@ private NetworkAddress() {}
      * @return formatted string
      */
     public static String format(InetAddress address) {
-        return format(address, new PortsRange(""));
+        return InetAddresses.toAddrString(address);
     }
 
     /**
@@ -96,7 +96,7 @@ public static String format(InetSocketAddress address) {
      * @return formatted string
      */
     public static String format(InetAddress address, int port) {
-        return format(address, new PortsRange(String.valueOf(port)));
+        return (address instanceof Inet6Address ? InetAddresses.toUriString(address) : InetAddresses.toAddrString(address)) + ":" + port;
     }
 
     /**

server/src/main/java/org/elasticsearch/transport/TaskTransportChannel.java

@@ -9,7 +9,6 @@
 package org.elasticsearch.transport;
 
 import org.elasticsearch.TransportVersion;
-import org.elasticsearch.common.Strings;
 import org.elasticsearch.core.Releasable;
 
 public class TaskTransportChannel implements TransportChannel {
@@ -58,6 +57,6 @@ public TransportChannel getChannel() {
 
     @Override
     public String toString() {
-        return Strings.format("TaskTransportChannel{task=%d}{%s}", taskId, channel);
+        return "TaskTransportChannel{task=" + taskId + "}{" + channel + "}";
     }
 }

server/src/main/java/org/elasticsearch/transport/TcpTransportChannel.java

@@ -9,7 +9,6 @@
 package org.elasticsearch.transport;
 
 import org.elasticsearch.TransportVersion;
-import org.elasticsearch.common.Strings;
 import org.elasticsearch.core.Releasable;
 
 public final class TcpTransportChannel implements TransportChannel {
@@ -89,6 +88,6 @@ public TcpChannel getChannel() {
 
     @Override
     public String toString() {
-        return Strings.format("TcpTransportChannel{req=%d}{%s}{%s}", requestId, action, channel);
+        return "TcpTransportChannel{req=" + requestId + "}{" + action + "}{" + channel + "}";
     }
 }