Skip to content

Commit 30a3a3e

Browse files
committed
Add a note about completion time
1 parent 62d2106 commit 30a3a3e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.buildkite/scripts/generate-pr-performance-benchmark.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ set -euo pipefail
77
# local command=$1
88
# echo "$@"
99
# if [ "$command" == "annotate" ]; then
10-
# while read -r _; do
11-
# true;
10+
# while read -r line; do
11+
# echo " read: $line";
1212
# done
1313
# fi
1414
#}
@@ -20,7 +20,8 @@ merge_base=$(git merge-base "${GITHUB_PR_TARGET_BRANCH}" HEAD)
2020
# PR comment
2121
buildkite-agent meta-data set pr_comment:early_comment_job_id "$BUILDKITE_JOB_ID"
2222
buildkite-agent meta-data set pr_comment:custom-body:body \
23-
"This build attempts two ${GITHUB_PR_COMMENT_VAR_BENCHMARK} benchmarks to evaluate performance impact of this PR."
23+
"This build attempts two ${GITHUB_PR_COMMENT_VAR_BENCHMARK} benchmarks to evaluate performance impact of this PR." \
24+
"To estimate benchmark completion time inspect previous nightly runs [here](https://buildkite.com/elastic/elasticsearch-performance-esbench-nightly/builds?branch=master)."
2425
buildkite-agent meta-data set pr_comment:custom-baseline:head \
2526
"* Baseline: ${merge_base} (env ID ${env_id_baseline})"
2627
buildkite-agent meta-data set pr_comment:custom-contender:head \
@@ -29,6 +30,7 @@ buildkite-agent meta-data set pr_comment:custom-contender:head \
2930
# Buildkite annotation
3031
cat << _EOF1_ | buildkite-agent annotate --context "pr-benchmark-notification"
3132
This build attempts two ${GITHUB_PR_COMMENT_VAR_BENCHMARK} benchmarks to evaluate performance impact of PR [${GITHUB_PR_NUMBER}](https://github.com/elastic/elasticsearch/pull/${GITHUB_PR_NUMBER}).
33+
To estimate benchmark completion time inspect previous nightly runs [here](https://buildkite.com/elastic/elasticsearch-performance-esbench-nightly/builds?branch=master).
3234
* Baseline: [${merge_base:0:7}](https://github.com/elastic/elasticsearch/commit/${merge_base}) (env ID ${env_id_baseline})
3335
* Contender: [${GITHUB_PR_TRIGGERED_SHA:0:7}](https://github.com/elastic/elasticsearch/commit/${GITHUB_PR_TRIGGERED_SHA}) (env ID ${env_id_contender})
3436
_EOF1_

0 commit comments

Comments
 (0)