Skip to content

Commit 30beb11

Browse files
authored
ESQL: Fix DEBUG log of filter (#116086)
This fixes the `DEBUG` level logging of `WHERE`. Previously it was using a `ThrowingDriverContext` to render the description - but this throwing context will, well, throw if you touch it. This removes the `ThrowingDriverContext` entirely because it's never the right thing to use - instead we just use the `toString` of the factories. That works fine because we made sure that the factories had a nice `toString`. Closes #116055
1 parent dbf55f5 commit 30beb11

File tree

3 files changed

+7
-85
lines changed

3 files changed

+7
-85
lines changed

docs/changelog/116086.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
pr: 116086
2+
summary: "ESQL: Fix DEBUG log of filter"
3+
area: ES|QL
4+
type: bug
5+
issues:
6+
- 116055

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/FilterOperator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public Operator get(DriverContext driverContext) {
2828

2929
@Override
3030
public String describe() {
31-
return "FilterOperator[evaluator=" + evaluatorSupplier.get(new ThrowingDriverContext()) + "]";
31+
return "FilterOperator[evaluator=" + evaluatorSupplier + "]";
3232
}
3333
}
3434

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/ThrowingDriverContext.java

Lines changed: 0 additions & 84 deletions
This file was deleted.

0 commit comments

Comments
 (0)