Skip to content

Commit 30deddd

Browse files
committed
Comment
1 parent 22c21d9 commit 30deddd

File tree

1 file changed

+2
-0
lines changed
  • modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3

1 file changed

+2
-0
lines changed

modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3Service.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,8 @@ static ClientOverrideConfiguration buildConfiguration(S3ClientSettings clientSet
257257
clientOverrideConfiguration.retryStrategy(builder -> {
258258
builder.maxAttempts(clientSettings.maxRetries);
259259
// TODO NOMERGE: revisit this, does it still make sense to specially retry?
260+
// -- dct: yes, in serverless we sometimes get 403s during because of delays in propagating updated credentials
261+
// (IAM is not strongly consistent); TODO NOMERGE this should be covered by some end-to-end test
260262
if (isStateless) {
261263
// Create a 403 error retyable policy.
262264
builder.retryOnException(S3Service::RETRYABLE_403_RETRY_PREDICATE);

0 commit comments

Comments
 (0)