Allow ESQL extra verifiers to access settings

Author: mark-vieira

x-pack/plugin/esql/qa/server/extra-checkers/build.gradle

@@ -7,6 +7,7 @@
 
 package org.elasticsearch.xpack.esql.analysis;
 
+import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.license.XPackLicenseState;
 import org.elasticsearch.xpack.esql.LicenseAware;
 import org.elasticsearch.xpack.esql.capabilities.PostAnalysisPlanVerificationAware;
@@ -60,7 +61,7 @@ public interface ExtraCheckers {
          * Build a list of checks to perform on the plan. Each one is called once per
          * {@link LogicalPlan} node in the plan.
          */
-        List<BiConsumer<LogicalPlan, Failures>> extra();
+        List<BiConsumer<LogicalPlan, Failures>> extra(Settings settings);
     }
 
     /**
@@ -69,15 +70,17 @@ public interface ExtraCheckers {
     private final List<ExtraCheckers> extraCheckers;
     private final Metrics metrics;
     private final XPackLicenseState licenseState;
+    private final Settings settings;
 
     public Verifier(Metrics metrics, XPackLicenseState licenseState) {
-        this(metrics, licenseState, Collections.emptyList());
+        this(metrics, licenseState, Collections.emptyList(), Settings.EMPTY);
     }
 
-    public Verifier(Metrics metrics, XPackLicenseState licenseState, List<ExtraCheckers> extraCheckers) {
+    public Verifier(Metrics metrics, XPackLicenseState licenseState, List<ExtraCheckers> extraCheckers, Settings settings) {
         this.metrics = metrics;
         this.licenseState = licenseState;
         this.extraCheckers = extraCheckers;
+        this.settings = settings;
     }
 
     /**
@@ -102,7 +105,7 @@ Collection<Failure> verify(LogicalPlan plan, BitSet partialMetrics) {
         // collect plan checkers
         var planCheckers = planCheckers(plan);
         for (ExtraCheckers e : extraCheckers) {
-            planCheckers.addAll(e.extra());
+            planCheckers.addAll(e.extra(settings));
         }
 
         // Concrete verifications

x-pack/plugin/esql/qa/server/extra-checkers/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/extra/ExtraCheckersIT.java

@@ -8,6 +8,7 @@
 package org.elasticsearch.xpack.esql.execution;
 
 import org.elasticsearch.action.ActionListener;
+import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.indices.IndicesExpressionGrouper;
 import org.elasticsearch.license.XPackLicenseState;
 import org.elasticsearch.telemetry.metric.MeterRegistry;
@@ -52,14 +53,15 @@ public PlanExecutor(
         MeterRegistry meterRegistry,
         XPackLicenseState licenseState,
         EsqlQueryLog queryLog,
-        List<Verifier.ExtraCheckers> extraCheckers
+        List<Verifier.ExtraCheckers> extraCheckers,
+        Settings settings
     ) {
         this.indexResolver = indexResolver;
         this.preAnalyzer = new PreAnalyzer();
         this.functionRegistry = new EsqlFunctionRegistry();
         this.mapper = new Mapper();
         this.metrics = new Metrics(functionRegistry);
-        this.verifier = new Verifier(metrics, licenseState, extraCheckers);
+        this.verifier = new Verifier(metrics, licenseState, extraCheckers, settings);
         this.planTelemetryManager = new PlanTelemetryManager(meterRegistry);
         this.queryLog = queryLog;
     }

x-pack/plugin/esql/qa/server/extra-checkers/src/main/java/org/elasticsearch/xpack/esql/qa/extra/DisallowCategorize.java

@@ -82,6 +82,7 @@
 import java.util.Collection;
 import java.util.List;
 import java.util.Objects;
+import java.util.Set;
 import java.util.function.Predicate;
 import java.util.function.Supplier;
 
@@ -190,6 +191,11 @@ public class EsqlPlugin extends Plugin implements ActionPlugin, ExtensiblePlugin
     );
 
     private final List<Verifier.ExtraCheckers> extraCheckers = new ArrayList<>();
+    private final Settings settings;
+
+    public EsqlPlugin(Settings settings) {
+        this.settings = settings;
+    }
 
     @Override
     public Collection<?> createComponents(PluginServices services) {
@@ -209,7 +215,8 @@ public Collection<?> createComponents(PluginServices services) {
                 services.telemetryProvider().getMeterRegistry(),
                 getLicenseState(),
                 new EsqlQueryLog(services.clusterService().getClusterSettings(), services.slowLogFieldProvider()),
-                extraCheckers
+                extraCheckers,
+                settings
             ),
             new ExchangeService(
                 services.clusterService().getSettings(),

x-pack/plugin/esql/qa/server/extra-checkers/src/main/java/org/elasticsearch/xpack/esql/qa/extra/ExtraCheckersPlugin.java

@@ -150,7 +150,14 @@ public void testFailedMetric() {
             return null;
         }).when(esqlClient).execute(eq(EsqlResolveFieldsAction.TYPE), any(), any());
 
-        var planExecutor = new PlanExecutor(indexResolver, MeterRegistry.NOOP, new XPackLicenseState(() -> 0L), mockQueryLog(), List.of());
+        var planExecutor = new PlanExecutor(
+            indexResolver,
+            MeterRegistry.NOOP,
+            new XPackLicenseState(() -> 0L),
+            mockQueryLog(),
+            List.of(),
+            Settings.EMPTY
+        );
         var enrichResolver = mockEnrichResolver();
 
         var request = new EsqlQueryRequest();