Skip to content

Commit 324f420

Browse files
Fix build
1 parent 3bbf8fe commit 324f420

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

server/src/internalClusterTest/java/org/elasticsearch/indices/SystemIndexMappingUpdateServiceIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public void testSystemIndexManagerUpgradesMappingsOfReindexedIndex() throws Exce
117117
ensureGreen(reindexedIndexName);
118118
assertAcked(
119119
indicesAdmin().aliases(
120-
new IndicesAliasesRequest(TEST_REQUEST_TIMEOUT, TEST_REQUEST_TIMEOUT).addAliasAction(
120+
new IndicesAliasesRequest().addAliasAction(
121121
IndicesAliasesRequest.AliasActions.add().index(reindexedIndexName).alias(PRIMARY_INDEX_NAME)
122122
).addAliasAction(IndicesAliasesRequest.AliasActions.add().index(reindexedIndexName).alias(INDEX_NAME))
123123
).actionGet()

server/src/main/java/org/elasticsearch/indices/SystemIndexMappingUpdateService.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ public void onFailure(Exception e) {
229229
* @return a summary of the index state, or <code>null</code> if the index doesn't exist
230230
*/
231231
static State calculateIndexState(ClusterState state, SystemIndexDescriptor descriptor) {
232-
IndexMetadata indexMetadata = getSystemIndexMetadata(state, descriptor);
232+
IndexMetadata indexMetadata = getSystemIndexMetadata(state.metadata(), descriptor);
233233

234234
if (indexMetadata == null) {
235235
return null;
@@ -258,16 +258,15 @@ static State calculateIndexState(ClusterState state, SystemIndexDescriptor descr
258258
return new State(indexState, indexHealth, isIndexUpToDate, isMappingIsUpToDate);
259259
}
260260

261-
private static IndexMetadata getSystemIndexMetadata(ProjectState state, SystemIndexDescriptor descriptor) {
261+
private static IndexMetadata getSystemIndexMetadata(Metadata metadata, SystemIndexDescriptor descriptor) {
262262
String primaryIndexName = descriptor.getPrimaryIndex();
263-
ProjectMetadata projectMetadata = state.metadata();
264-
IndexMetadata indexMetadata = projectMetadata.index(primaryIndexName);
263+
IndexMetadata indexMetadata = metadata.index(primaryIndexName);
265264
if (indexMetadata == null) {
266265
// The primary index name might be an alias pointing to the concrete index
267266
// (e.g. ".fleet-agents-7" → ".fleet-agents-7-reindexed-for-9").
268-
IndexAbstraction indexAbstraction = projectMetadata.getIndicesLookup().get(primaryIndexName);
267+
IndexAbstraction indexAbstraction = metadata.getIndicesLookup().get(primaryIndexName);
269268
if (indexAbstraction != null && indexAbstraction.getWriteIndex() != null) {
270-
indexMetadata = projectMetadata.getIndexSafe(indexAbstraction.getWriteIndex());
269+
indexMetadata = metadata.getIndexSafe(indexAbstraction.getWriteIndex());
271270
}
272271
}
273272
return indexMetadata;

server/src/test/java/org/elasticsearch/indices/SystemIndexMappingUpdateServiceTests.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import org.elasticsearch.cluster.ClusterChangedEvent;
1717
import org.elasticsearch.cluster.ClusterName;
1818
import org.elasticsearch.cluster.ClusterState;
19+
import org.elasticsearch.cluster.TestShardRoutingRoleStrategies;
1920
import org.elasticsearch.cluster.metadata.AliasMetadata;
2021
import org.elasticsearch.cluster.metadata.IndexMetadata;
2122
import org.elasticsearch.cluster.metadata.Metadata;
@@ -279,7 +280,6 @@ public void testManagerSubmitsPutRequest() {
279280
*/
280281
public void testManagerDetectsOutdatedMappingsInReindexedIndex() {
281282
final String reindexedIndexName = SYSTEM_INDEX_NAME + SystemIndices.UPGRADED_INDEX_SUFFIX;
282-
final var projectId = randomProjectIdOrDefault();
283283

284284
// Simulate the post-migration state: the concrete index has the reindexed suffix and an
285285
// outdated managed_index_mappings_version, while the original primary index name and the
@@ -290,21 +290,19 @@ public void testManagerDetectsOutdatedMappingsInReindexedIndex() {
290290
.putAlias(AliasMetadata.builder(SYSTEM_INDEX_NAME).build())
291291
.putAlias(AliasMetadata.builder(DESCRIPTOR.getAliasName()).build());
292292

293-
final Metadata metadata = Metadata.builder()
294-
.generateClusterUuidIfNeeded()
295-
.put(ProjectMetadata.builder(projectId).put(reindexedIndexMeta))
296-
.build();
293+
final Metadata metadata = Metadata.builder().generateClusterUuidIfNeeded().put(reindexedIndexMeta).build();
297294
final DiscoveryNode node = DiscoveryNodeUtils.builder("1").roles(new HashSet<>(DiscoveryNodeRole.roles())).build();
298295
final DiscoveryNodes nodes = DiscoveryNodes.builder().add(node).masterNodeId(node.getId()).localNodeId(node.getId()).build();
299296
final ClusterState clusterState = ClusterState.builder(CLUSTER_NAME)
300297
.nodes(nodes)
301298
.metadata(metadata)
302-
.routingTable(GlobalRoutingTableTestHelper.buildRoutingTable(metadata, RoutingTable.Builder::addAsNew))
299+
.routingTable(
300+
RoutingTable.builder(TestShardRoutingRoleStrategies.DEFAULT_ROLE_ONLY).addAsNew(metadata.index(reindexedIndexName))
301+
)
303302
.build();
304-
ProjectState projectState = clusterState.projectState(projectId);
305303

306304
assertThat(
307-
SystemIndexMappingUpdateService.getUpgradeStatus(projectState, DESCRIPTOR),
305+
SystemIndexMappingUpdateService.getUpgradeStatus(clusterState, DESCRIPTOR),
308306
equalTo(UpgradeStatus.NEEDS_MAPPINGS_UPDATE)
309307
);
310308
}

0 commit comments

Comments
 (0)