better validation before migrating

Author: rjernst

build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/transport/TransportVersionManagementPluginFuncTest.groovy

@@ -275,7 +275,7 @@ class TransportVersionManagementPluginFuncTest extends AbstractGradleFuncTest {
         when:
         def result = validateDefinitionsFails()
         then:
-        assertDefinitionsFailure(result, "Transport version base version 8013000 is missing patch version 8013001")
+        assertDefinitionsFailure(result, "Transport version base id 8013000 is missing patch ids between 8013000 and 8013002")
     }
 
     def "primary id must not be patch version"() {

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/ValidateTransportVersionDefinitionsTask.java

@@ -293,10 +293,14 @@ private void cleanupAndValidateBase(int base, List<IdAndDefinition> ids) {
         // first sort the ids list so we can check compactness and quickly lookup the highest id later
         ids.sort(Comparator.comparingInt(a -> a.id().complete()));
 
-        for (int ndx = 0; ndx < ids.size(); ++ndx) {
-            IdAndDefinition idAndDefinition = ids.get(ndx);
-            if (idAndDefinition.id().patch() != ndx) {
-                throw new IllegalStateException("Transport version base version " + base + " is missing patch version " + (base + ndx));
+        // TODO: switch this to a fully dense check once all existing transport versions have been migrated
+        IdAndDefinition previous = ids.getLast();
+        for (int ndx = ids.size() - 2; ndx >= 0; --ndx) {
+            IdAndDefinition next = ids.get(ndx);
+            // note that next and previous are reversed here because we are iterating in reverse order
+            if (previous.id().complete() - 1 != next.id().complete()) {
+                throw new IllegalStateException("Transport version base id " + base +
+                    " is missing patch ids between " + next.id() + " and " + previous.id());
             }
         }
     }

server/src/main/resources/transport/defined/mappings_in_data_streams.csv

@@ -0,0 +1 @@
+9112000