Skip to content

Commit 357277e

Browse files
author
Max Hniebergall
committed
remove old todos
1 parent bc7dbb8 commit 357277e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/request/openai/OpenAiUnifiedChatCompletionRequestEntityTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,10 +269,10 @@ public void testSerializationWithEmptyLists() throws IOException {
269269
messageList,
270270
null, // model
271271
null, // maxCompletionTokens
272-
Collections.emptyList(), // empty stop list TODO when passing an empty stop-list, should it be converted to null?
272+
Collections.emptyList(), // empty stop list
273273
null, // temperature
274274
null, // toolChoice
275-
Collections.emptyList(), // empty tools list TODO when passing an empty tools-list, should it be converted to null?
275+
Collections.emptyList(), // empty tools list
276276
null // topP
277277
);
278278

0 commit comments

Comments
 (0)