Remove license checking mechanism from tests (unsupported in 8.x)

Author: craigtaverner

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/SpatialGridFunction.java

@@ -208,7 +208,7 @@ protected static void addGrids(LongBlock.Builder results, List<Long> gridIds) {
         if (gridIds.isEmpty()) {
             results.appendNull();
         } else if (gridIds.size() == 1) {
-            results.appendLong(gridIds.getFirst());
+            results.appendLong(gridIds.get(0));
         } else {
             results.beginPositionEntry();
             for (long gridId : gridIds) {

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeohashToLong.java

@@ -44,8 +44,7 @@ public class StGeohashToLong extends AbstractConvertFunction implements Evaluato
     @FunctionInfo(
         returnType = "long",
         description = "Converts an input value representing a geohash grid-ID in string format into a long.",
-        examples = { @Example(file = "spatial-grid", tag = "geohash_to_long") },
-        depthOffset = 1 // make it appear as a subsection of ST_GEOHASH
+        examples = { @Example(file = "spatial-grid", tag = "geohash_to_long") }
     )
     public StGeohashToLong(
         Source source,

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeohashToString.java

@@ -44,8 +44,7 @@ public class StGeohashToString extends AbstractConvertFunction implements Evalua
     @FunctionInfo(
         returnType = "keyword",
         description = "Converts an input value representing a geohash grid-ID in long format into a string.",
-        examples = { @Example(file = "spatial-grid", tag = "geohash_to_string") },
-        depthOffset = 1 // make it appear as a subsection of ST_GEOHASH
+        examples = { @Example(file = "spatial-grid", tag = "geohash_to_string") }
     )
     public StGeohashToString(
         Source source,

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeohexToLong.java

@@ -44,8 +44,7 @@ public class StGeohexToLong extends AbstractConvertFunction implements Evaluator
     @FunctionInfo(
         returnType = "long",
         description = "Converts an input value representing a geohex grid-ID in string format into a long.",
-        examples = { @Example(file = "spatial-grid", tag = "geohex_to_long") },
-        depthOffset = 1 // make it appear as a subsection of ST_GEOHEX
+        examples = { @Example(file = "spatial-grid", tag = "geohex_to_long") }
     )
     public StGeohexToLong(
         Source source,

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeohexToString.java

@@ -44,8 +44,7 @@ public class StGeohexToString extends AbstractConvertFunction implements Evaluat
     @FunctionInfo(
         returnType = "keyword",
         description = "Converts an input value representing a Geohex grid-ID in long format into a string.",
-        examples = { @Example(file = "spatial-grid", tag = "geohex_to_string") },
-        depthOffset = 1 // make it appear as a subsection of ST_GEOHEX
+        examples = { @Example(file = "spatial-grid", tag = "geohex_to_string") }
     )
     public StGeohexToString(
         Source source,

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeotileToLong.java

@@ -44,8 +44,7 @@ public class StGeotileToLong extends AbstractConvertFunction implements Evaluato
     @FunctionInfo(
         returnType = "long",
         description = "Converts an input value representing a geotile grid-ID in string format into a long.",
-        examples = { @Example(file = "spatial-grid", tag = "geotile_to_long") },
-        depthOffset = 1 // make it appear as a subsection of ST_GEOTILE
+        examples = { @Example(file = "spatial-grid", tag = "geotile_to_long") }
     )
     public StGeotileToLong(
         Source source,

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeotileToString.java

@@ -44,8 +44,7 @@ public class StGeotileToString extends AbstractConvertFunction implements Evalua
     @FunctionInfo(
         returnType = "keyword",
         description = "Converts an input value representing a geotile grid-ID in long format into a string.",
-        examples = { @Example(file = "spatial-grid", tag = "geotile_to_string") },
-        depthOffset = 1 // make it appear as a subsection of ST_GEOTILE
+        examples = { @Example(file = "spatial-grid", tag = "geotile_to_string") }
     )
     public StGeotileToString(
         Source source,

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/SpatialGridFunctionTestCase.java

@@ -13,7 +13,6 @@
 import org.elasticsearch.compute.operator.EvalOperator;
 import org.elasticsearch.geometry.Point;
 import org.elasticsearch.geometry.Rectangle;
-import org.elasticsearch.license.License;
 import org.elasticsearch.xpack.esql.core.expression.Literal;
 import org.elasticsearch.xpack.esql.core.tree.Source;
 import org.elasticsearch.xpack.esql.core.type.DataType;
@@ -41,26 +40,6 @@ protected interface TriFunction<T, U, V, R> {
         R apply(T t, U u, V v);
     }
 
-    /**
-     * All spatial grid functions have one license requirement in common, and that is that they are licensed aty PLATINUM level
-     * oif the spatial field is a shape, otherwise they are licensed at BASIC level. This is to mimic the license requirements
-     * of the spatial aggregations.
-     * @param fieldTypes (null for the function itself, otherwise a map of field named to types)
-     * @return The license requirement for the function with that type signature
-     */
-    protected static License.OperationMode licenseRequirement(List<DataType> fieldTypes) {
-        if (fieldTypes == null || fieldTypes.isEmpty()) {
-            // The function itself is not licensed, but the field types are.
-            return License.OperationMode.BASIC;
-        }
-        if (DataType.isSpatialShape(fieldTypes.getFirst())) {
-            // Only aggregations over shapes are licensed under platinum.
-            return License.OperationMode.PLATINUM;
-        }
-        // All other field types are licensed under basic.
-        return License.OperationMode.BASIC;
-    }
-
     private static String getFunctionClassName() {
         Class<?> testClass = getTestClass();
         String testClassName = testClass.getSimpleName();
@@ -126,23 +105,23 @@ protected static void addTestCaseSuppliers(
     public static TestCaseSupplier.TypedDataSupplier testCaseSupplier(DataType dataType, boolean pointsOnly) {
         if (pointsOnly) {
             return switch (dataType.esType()) {
-                case "geo_point" -> TestCaseSupplier.geoPointCases(() -> false).getFirst();
-                case "cartesian_point" -> TestCaseSupplier.cartesianPointCases(() -> false).getFirst();
+                case "geo_point" -> TestCaseSupplier.geoPointCases(() -> false).get(0);
+                case "cartesian_point" -> TestCaseSupplier.cartesianPointCases(() -> false).get(0);
                 default -> throw new IllegalArgumentException("Unsupported datatype for " + functionName() + ": " + dataType);
             };
         } else {
             return switch (dataType.esType()) {
-                case "geo_point" -> TestCaseSupplier.geoPointCases(() -> false).getFirst();
-                case "geo_shape" -> TestCaseSupplier.geoShapeCases(() -> false).getFirst();
-                case "cartesian_point" -> TestCaseSupplier.cartesianPointCases(() -> false).getFirst();
-                case "cartesian_shape" -> TestCaseSupplier.cartesianShapeCases(() -> false).getFirst();
+                case "geo_point" -> TestCaseSupplier.geoPointCases(() -> false).get(0);
+                case "geo_shape" -> TestCaseSupplier.geoShapeCases(() -> false).get(0);
+                case "cartesian_point" -> TestCaseSupplier.cartesianPointCases(() -> false).get(0);
+                case "cartesian_shape" -> TestCaseSupplier.cartesianShapeCases(() -> false).get(0);
                 default -> throw new IllegalArgumentException("Unsupported datatype for " + functionName() + ": " + dataType);
             };
         }
     }
 
     protected Long process(int precision, BiFunction<BytesRef, Integer, Long> expectedValue) {
-        Object spatialObj = this.testCase.getDataValues().getFirst();
+        Object spatialObj = this.testCase.getDataValues().get(0);
         assumeNotNull(spatialObj);
         assumeTrue("Expected a BytesRef, but got " + spatialObj.getClass(), spatialObj instanceof BytesRef);
         BytesRef wkb = (BytesRef) spatialObj;
@@ -157,7 +136,7 @@ protected Long process(int precision, BiFunction<BytesRef, Integer, Long> expect
     }
 
     protected Long process(BytesRef bounds, BiFunction<BytesRef, BytesRef, Long> expectedValue) {
-        Object spatialObj = this.testCase.getDataValues().getFirst();
+        Object spatialObj = this.testCase.getDataValues().get(0);
         assumeNotNull(spatialObj);
         assumeTrue("Expected a BytesRef, but got " + spatialObj.getClass(), spatialObj instanceof BytesRef);
         BytesRef wkb = (BytesRef) spatialObj;

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeohashTests.java

@@ -31,14 +31,6 @@ public StGeohashTests(@Name("TestCase") Supplier<TestCaseSupplier.TestCase> test
         this.testCase = testCaseSupplier.get();
     }
 
-    /**
-     * Since geo grid functions are primarily used for spatial aggregations,
-     * we use the same license requirement as the spatial aggregations.
-     */
-    public static License.OperationMode licenseRequirement(List<DataType> fieldTypes) {
-        return SpatialGridFunctionTestCase.licenseRequirement(fieldTypes);
-    }
-
     @ParametersFactory
     public static Iterable<Object[]> parameters() {
         final List<TestCaseSupplier> suppliers = new ArrayList<>();

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeohexTests.java

@@ -31,14 +31,6 @@ public StGeohexTests(@Name("TestCase") Supplier<TestCaseSupplier.TestCase> testC
         this.testCase = testCaseSupplier.get();
     }
 
-    /**
-     * Other geo grid functions use the same type-specific license requirement as the spatial aggregations, but geohex is licensed
-     * more strictly, at platinum for all field types.
-     */
-    public static License.OperationMode licenseRequirement(List<DataType> fieldTypes) {
-        return License.OperationMode.PLATINUM;
-    }
-
     @ParametersFactory
     public static Iterable<Object[]> parameters() {
         final List<TestCaseSupplier> suppliers = new ArrayList<>();