Skip to content

Commit 3687453

Browse files
committed
Merge remote-tracking branch 'upstream/main' into include-default-index-sort-2
2 parents e13b33d + c2cdc0a commit 3687453

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

docs/changelog/135851.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
pr: 135851
2+
summary: DiskBBQ - missing min competitive similarity check on tail docs
3+
area: Vector Search
4+
type: bug
5+
issues: []

muted-tests.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -630,6 +630,9 @@ tests:
630630
- class: org.elasticsearch.xpack.esql.action.CrossClusterQueryWithPartialResultsIT
631631
method: testOneRemoteClusterPartial
632632
issue: https://github.com/elastic/elasticsearch/issues/124055
633+
- class: org.elasticsearch.datastreams.DataStreamIndexSettingsProviderTests
634+
method: testGetAdditionalIndexSettingsMappingsMerging
635+
issue: https://github.com/elastic/elasticsearch/issues/135884
633636

634637
# Examples:
635638
#

server/src/main/java/org/elasticsearch/index/codec/vectors/diskbbq/ES920DiskBBQVectorsReader.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,9 @@ public int visit(KnnCollector knnCollector) throws IOException {
568568
qcDist
569569
);
570570
scoredDocs++;
571-
knnCollector.collect(doc, score);
571+
if (knnCollector.minCompetitiveSimilarity() < score) {
572+
knnCollector.collect(doc, score);
573+
}
572574
} else {
573575
indexInput.skipBytes(quantizedByteLength);
574576
}

0 commit comments

Comments
 (0)