Skip to content

Commit 36d9245

Browse files
committed
Remove code related to fixed bugs
1 parent 85d375c commit 36d9245

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/EsqlQueryGenerator.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -225,8 +225,7 @@ private static String keep(List<Column> previousOutput) {
225225

226226
private static String randomName(List<Column> previousOutput) {
227227
String result = randomRawName(previousOutput);
228-
if (result.isEmpty() // bug https://github.com/elastic/elasticsearch/issues/125870, we'll manage it as an error later
229-
|| (randomBoolean() && result.contains("*") == false)) {
228+
if ((randomBoolean() && result.contains("*") == false)) {
230229
result = "`" + result + "`";
231230
}
232231
return result;
@@ -311,12 +310,10 @@ private static String rename(List<Column> previousOutput) {
311310
continue;
312311
}
313312
nameToType.put(newName, nameToType.get(name));
314-
if (name.length() == 0 // https://github.com/elastic/elasticsearch/issues/125870, we'll manage it as an error later
315-
|| (randomBoolean() && name.startsWith("`") == false)) {
313+
if (randomBoolean() && name.startsWith("`") == false) {
316314
name = "`" + name + "`";
317315
}
318-
if (newName.length() == 0 // https://github.com/elastic/elasticsearch/issues/125870, we'll manage it as an error later
319-
|| (randomBoolean() && newName.startsWith("`") == false)) {
316+
if (randomBoolean() && newName.startsWith("`") == false) {
320317
newName = "`" + newName + "`";
321318
}
322319
proj.add(name + " AS " + newName);

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/GenerativeRestTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ public abstract class GenerativeRestTest extends ESRestTestCase {
5050
// Awaiting fixes
5151
"Unknown column \\[<all-fields-projected>\\]", // https://github.com/elastic/elasticsearch/issues/121741,
5252
"Plan \\[ProjectExec\\[\\[<no-fields>.* optimized incorrectly due to missing references", // https://github.com/elastic/elasticsearch/issues/125866
53-
"token recognition error at: ", // https://github.com/elastic/elasticsearch/issues/125870
54-
// https://github.com/elastic/elasticsearch/issues/127167
5553
"optimized incorrectly due to missing references", // https://github.com/elastic/elasticsearch/issues/116781
5654
"No matches found for pattern", // https://github.com/elastic/elasticsearch/issues/126418
5755
"Unknown column", // https://github.com/elastic/elasticsearch/issues/127467

0 commit comments

Comments
 (0)