text-field subclass

Author: not-napoleon

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/EsField.java

@@ -87,6 +87,7 @@ public static TimeSeriesFieldType readFromStream(StreamInput in) throws IOExcept
 
         public static TimeSeriesFieldType fromIndexFieldCapabilities(IndexFieldCapabilities capabilities) {
             if (capabilities.isDimension()) {
+                assert capabilities.metricType() == null;
                 return DIMENSION;
             }
             if (capabilities.metricType() != null) {

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/TextEsField.java

@@ -25,14 +25,6 @@
  */
 public class TextEsField extends EsField {
 
-    public TextEsField(String name, Map<String, EsField> properties, boolean hasDocValues) {
-        this(name, properties, hasDocValues, false);
-    }
-
-    public TextEsField(String name, Map<String, EsField> properties, boolean hasDocValues, boolean isAlias) {
-        super(name, TEXT, properties, hasDocValues, isAlias, TimeSeriesFieldType.UNKNOWN);
-    }
-
     public TextEsField(
         String name,
         Map<String, EsField> properties,

x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/LoadMapping.java

@@ -102,7 +102,7 @@ private static void walkMapping(String name, Object value, Map<String, EsField>
             boolean docValues = boolSetting(content.get("doc_values"), esDataType.hasDocValues());
             final EsField field;
             if (esDataType == TEXT) {
-                field = new TextEsField(name, properties, docValues);
+                field = new TextEsField(name, properties, docValues, false, EsField.TimeSeriesFieldType.NONE);
             } else if (esDataType == KEYWORD) {
                 int length = intSetting(content.get("ignore_above"), Short.MAX_VALUE);
                 boolean normalized = Strings.hasText(textSetting(content.get("normalizer"), null));

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/type/TextEsFieldTests.java

@@ -18,7 +18,8 @@ static TextEsField randomTextEsField(int maxPropertiesDepth) {
         Map<String, EsField> properties = randomProperties(maxPropertiesDepth);
         boolean hasDocValues = randomBoolean();
         boolean isAlias = randomBoolean();
-        return new TextEsField(name, properties, hasDocValues, isAlias);
+        EsField.TimeSeriesFieldType tsType = randomFrom(EsField.TimeSeriesFieldType.values());
+        return new TextEsField(name, properties, hasDocValues, isAlias, tsType);
     }
 
     @Override
@@ -32,13 +33,15 @@ protected TextEsField mutate(TextEsField instance) {
         Map<String, EsField> properties = instance.getProperties();
         boolean hasDocValues = instance.isAggregatable();
         boolean isAlias = instance.isAlias();
-        switch (between(0, 3)) {
+        EsField.TimeSeriesFieldType tsType = instance.getTimeSeriesFieldType();
+        switch (between(0, 4)) {
             case 0 -> name = randomAlphaOfLength(name.length() + 1);
             case 1 -> properties = randomValueOtherThan(properties, () -> randomProperties(4));
             case 2 -> hasDocValues = false == hasDocValues;
             case 3 -> isAlias = false == isAlias;
+            case 4 -> tsType = randomValueOtherThan(tsType, () -> randomFrom(EsField.TimeSeriesFieldType.values()));
             default -> throw new IllegalArgumentException();
         }
-        return new TextEsField(name, properties, hasDocValues, isAlias);
+        return new TextEsField(name, properties, hasDocValues, isAlias, tsType);
     }
 }