Skip to content

Commit 3896de6

Browse files
authored
ESQL: Fix AttributeSet#add() returning the opposite expected value (#117367)
Set/Collection#add() is supposed to return `true` if the collection changed (If it actually added something). In this case, it must return if the old value is null. Extracted from #114317 (Where it's being used)
1 parent 32aaacb commit 3896de6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/AttributeSet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public <T> T[] toArray(T[] a) {
113113

114114
@Override
115115
public boolean add(Attribute e) {
116-
return delegate.put(e, PRESENT) != null;
116+
return delegate.put(e, PRESENT) == null;
117117
}
118118

119119
@Override

x-pack/plugin/ql/src/main/java/org/elasticsearch/xpack/ql/expression/AttributeSet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public <T> T[] toArray(T[] a) {
113113

114114
@Override
115115
public boolean add(Attribute e) {
116-
return delegate.put(e, PRESENT) != null;
116+
return delegate.put(e, PRESENT) == null;
117117
}
118118

119119
@Override

0 commit comments

Comments
 (0)