fix comments

Author: idegtiarenko

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/NamedExpression.java

@@ -62,9 +62,9 @@ public int hashCode() {
     }
 
     /**
-     * Polymorphic equality is a pain.
-     * This equals shortcuts `this == o` and type checks.
-     * Here equals is final to ensure we are not duplication those checks.
+     * Polymorphic equality is a pain and are likely slower than a regular ones.
+     * This equals shortcuts `this == o` and type checks (important when we expect only a few non-equal objects).
+     * Here equals is final to ensure we are not duplicating those checks.
      * For actual equality check override `innerEquals` instead.
      */
     @Override

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/UnresolvedAttribute.java

@@ -21,8 +21,8 @@
 
 // unfortunately we can't use UnresolvedNamedExpression
 public class UnresolvedAttribute extends Attribute implements Unresolvable {
-    private final String unresolvedMsg;
     private final boolean customMessage;
+    private final String unresolvedMsg;
     private final Object resolutionMetadata;
 
     public UnresolvedAttribute(Source source, String name) {
@@ -128,8 +128,7 @@ public int hashCode() {
     protected boolean innerEquals(Object o) {
         var other = (UnresolvedAttribute) o;
         return super.innerEquals(other)
-            && customMessage == other.customMessage
-            && Objects.equals(unresolvedMsg, other.unresolvedMsg)
-            && Objects.equals(resolutionMetadata, other.resolutionMetadata);
+            && Objects.equals(resolutionMetadata, other.resolutionMetadata)
+            && Objects.equals(unresolvedMsg, other.unresolvedMsg);
     }
 }

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/UnsupportedAttribute.java

@@ -57,8 +57,8 @@ public final class UnsupportedAttribute extends FieldAttribute implements Unreso
         UnsupportedAttribute::readFrom
     );
 
-    private final String message;
     private final boolean hasCustomMessage; // TODO remove me and just use message != null?
+    private final String message;
 
     private static String errorMessage(String name, UnsupportedEsField field) {
         return "Cannot use field [" + name + "] with unsupported type [" + String.join(",", field.getOriginalTypes()) + "]";
@@ -165,7 +165,7 @@ public boolean hasCustomMessage() {
     @Override
     @SuppressWarnings("checkstyle:EqualsHashCode")// equals is implemented in parent. See innerEquals instead
     public int hashCode() {
-        return Objects.hash(super.hashCode(), message, hasCustomMessage);
+        return Objects.hash(super.hashCode(), hasCustomMessage, message);
     }
 
     @Override