Add enhancement for MV_APPEND supports 2-n number of arguments

Author: jackpan123

docs/reference/esql/functions/description/mv_append.asciidoc

@@ -699,6 +699,9 @@ public void unpackValues(MethodSpec.Builder builder, boolean blockStyle) {
             }
             if (componentType.equals(BYTES_REF)) {
                 builder.addStatement("$LValues[i] = $L[i].getBytesRef($L, $LScratch[i])", name, paramName(blockStyle), lookupVar, name);
+            } else if (componentType.equals(INT_BLOCK) || componentType.equals(LONG_BLOCK) || componentType.equals(DOUBLE_BLOCK)
+                || componentType.equals(BOOLEAN_BLOCK) || componentType.equals(BYTES_REF_BLOCK)) {
+                builder.addStatement("$LValues[i] = $L[i]", name, paramName(blockStyle));
             } else {
                 builder.addStatement("$LValues[i] = $L[i].$L($L)", name, paramName(blockStyle), getMethod(componentType), lookupVar);
             }

docs/reference/esql/functions/kibana/definition/mv_append.json

@@ -139,19 +139,19 @@ public class Types {
     static final ClassName RELEASABLES = ClassName.get("org.elasticsearch.core", "Releasables");
 
     static ClassName blockType(TypeName elementType) {
-        if (elementType.equals(TypeName.BOOLEAN)) {
+        if (elementType.equals(TypeName.BOOLEAN) || elementType.equals(BOOLEAN_BLOCK)) {
             return BOOLEAN_BLOCK;
         }
-        if (elementType.equals(BYTES_REF)) {
+        if (elementType.equals(BYTES_REF) || elementType.equals(BYTES_REF_BLOCK)) {
             return BYTES_REF_BLOCK;
         }
-        if (elementType.equals(TypeName.INT)) {
+        if (elementType.equals(TypeName.INT) || elementType.equals(INT_BLOCK)) {
             return INT_BLOCK;
         }
-        if (elementType.equals(TypeName.LONG)) {
+        if (elementType.equals(TypeName.LONG) || elementType.equals(LONG_BLOCK)) {
             return LONG_BLOCK;
         }
-        if (elementType.equals(TypeName.DOUBLE)) {
+        if (elementType.equals(TypeName.DOUBLE) || elementType.equals(DOUBLE_BLOCK)) {
             return DOUBLE_BLOCK;
         }
         throw new IllegalArgumentException("unknown block type for [" + elementType + "]");

docs/reference/esql/functions/kibana/docs/mv_append.md

@@ -540,12 +540,12 @@ FROM employees
        i = mv_append(salary_change.int, salary_change.int),
        i2 = mv_append(emp_no, salary_change.int),
        i3 = mv_append(emp_no, emp_no),  
-       s = mv_append(salary_change.keyword, salary_change.keyword)
+       s = mv_append(salary_change.keyword, salary_change.keyword, salary_change.keyword)
 | KEEP emp_no, salary_change, d, i, i2, i3, s
 | SORT emp_no;
 
 emp_no:integer | salary_change:double    | d:double                                       | i:integer              | i2:integer         | i3:integer     | s:keyword
-10008          | [-2.92,0.75,3.54,12.68] | [-2.92,0.75,3.54,12.68,-2.92,0.75,3.54,12.68]  | [-2,0,3,12,-2,0,3,12]  | [10008,-2,0,3,12]  | [10008, 10008] | [-2.92,0.75,12.68,3.54,-2.92,0.75,12.68,3.54]
+10008          | [-2.92,0.75,3.54,12.68] | [-2.92,0.75,3.54,12.68,-2.92,0.75,3.54,12.68]  | [-2,0,3,12,-2,0,3,12]  | [10008,-2,0,3,12]  | [10008, 10008] | [-2.92,0.75,12.68,3.54,-2.92,0.75,12.68,3.54,-2.92,0.75,12.68,3.54]
 10021          | null                    | null                                           | null                   | null               | [10021, 10021] | null
 ;
 

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/EvaluatorImplementer.java

@@ -1486,7 +1486,7 @@ mvAppend
 required_capability: fn_mv_append
 
 ROW a = "a", b = ["b", "c"], n = null
-| EVAL aa = mv_append(a, a), bb = mv_append(b, b), ab = mv_append(a, b), abb = mv_append(mv_append(a, b), b), na = mv_append(n, a), an = mv_append(a, n)
+| EVAL aa = mv_append(a, a), bb = mv_append(b, b), ab = mv_append(a, b), abb = mv_append(a, b, b), na = mv_append(n, a), an = mv_append(a, n)
 ;
 
 a:keyword | b:keyword | n:null | aa:keyword | bb:keyword   | ab:keyword | abb:keyword    | na:keyword | an:keyword

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/Types.java

@@ -1341,7 +1341,7 @@ multiIndexIndirectUseOfUnionTypesInMvExpand
 // make the csv tests work with multiple indices.
 required_capability: union_types
 FROM sample_data, sample_data_ts_long
-| EVAL foo = MV_APPEND(message, message)
+| EVAL foo = MV_APPEND(message, message, message)
 | SORT client_ip ASC
 | LIMIT 1
 | MV_EXPAND foo

x-pack/plugin/esql/qa/testFixtures/src/main/resources/floats.csv-spec

@@ -377,7 +377,7 @@ required_capability: fn_mv_append
 
 ROW a = to_version("1.2.0"), x1 = to_version("0.0.1"), x2 = to_version("1.0.0")
 | EVAL b = mv_append(x1, x2)
-| EVAL aa = mv_append(a, a), bb = mv_append(b, b), ab = mv_append(a, b), abb = mv_append(mv_append(a, b), b)
+| EVAL aa = mv_append(a, a), bb = mv_append(b, b), ab = mv_append(a, b), abb = mv_append(a, b, b)
 | KEEP a, b, aa, bb, ab, abb
 ;