Skip to content

Commit 3c57ced

Browse files
committed
Assert only if last ref in finally block
1 parent d926d33 commit 3c57ced

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

server/src/test/java/org/elasticsearch/search/SearchServiceSingleNodeTests.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2995,12 +2995,18 @@ public void testFetchPhaseAccountsForSourceMemoryUsage() throws Exception {
29952995
}
29962996
if (fetchSearchResult != null) {
29972997
long usedBeforeResultDecRef = breaker.getUsed();
2998-
fetchSearchResult.decRef();
2999-
assertThat(usedBeforeResultDecRef, greaterThanOrEqualTo(48_000L));
3000-
// when releasing the result references we should clear at least 48_000 bytes (48 hits with sources of at least 1000 bytes)
3001-
long usedAfterResultDecRef = breaker.getUsed();
3002-
logger.info("--> usedBeforeResultDecRef: [{}], usedAfterResultDecRef: [{}]", usedBeforeResultDecRef, usedAfterResultDecRef);
3003-
assertThat(usedBeforeResultDecRef - usedAfterResultDecRef, greaterThanOrEqualTo(48_000L));
2998+
if (fetchSearchResult.decRef()) {
2999+
assertThat(usedBeforeResultDecRef, greaterThanOrEqualTo(48_000L));
3000+
// when releasing the result references we should clear at least 48_000 bytes (48 hits with sources of at least 1000
3001+
// bytes)
3002+
long usedAfterResultDecRef = breaker.getUsed();
3003+
logger.info(
3004+
"--> usedBeforeResultDecRef: [{}], usedAfterResultDecRef: [{}]",
3005+
usedBeforeResultDecRef,
3006+
usedAfterResultDecRef
3007+
);
3008+
assertThat(usedBeforeResultDecRef - usedAfterResultDecRef, greaterThanOrEqualTo(48_000L));
3009+
}
30043010
}
30053011
}
30063012
}

0 commit comments

Comments
 (0)