Skip to content

Commit 3c77f00

Browse files
author
Pablo Alcantar Morales
authored
fix flaky docs tests get-lifecycle (#95529) (#95567)
The `data-streams/downsampling.asciidoc` test was missing a teardown clean of the ILM policies created. Due to this tests *do not have* the string `ilm` in its name, the automatic teardown process that cleans up the resources (check `ESRestTestCase.java#L815` & `DocsClientYamlTestSuiteIT.java` lines 177 & 195) is not executed for this specific test. In the case this test runs right before the `get-lifecycle` test, the policy won't be automatically deleted hence the test checking the version will fail. Finally, the order of execution of the test is not guaranteed by the suite.
1 parent e8b72b7 commit 3c77f00

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

docs/reference/data-streams/downsampling.asciidoc

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,14 @@
11
[[downsampling]]
2+
3+
/////
4+
[source,console]
5+
--------------------------------------------------
6+
DELETE _ilm/policy/my_policy
7+
--------------------------------------------------
8+
// TEST
9+
// TEARDOWN
10+
/////
11+
212
=== Downsampling a time series data stream
313

414
Downsampling provides a method to reduce the footprint of your <<tsds,time
@@ -120,8 +130,8 @@ There are a few things to note when querying downsampled indices:
120130
* When you run queries in {kib} and through Elastic solutions, a normal
121131
response is returned without notification that some of the queried indices are
122132
downsampled.
123-
* For
124-
<<search-aggregations-bucket-datehistogram-aggregation,date histogram aggregations>>,
133+
* For
134+
<<search-aggregations-bucket-datehistogram-aggregation,date histogram aggregations>>,
125135
only `fixed_intervals` (and not calendar-aware intervals) are supported.
126136
* Only Coordinated Universal Time (UTC) date-times are supported.
127137

@@ -131,13 +141,13 @@ only `fixed_intervals` (and not calendar-aware intervals) are supported.
131141

132142
The following restrictions and limitations apply for downsampling:
133143

134-
* Only indices in a <<tsds,time series data stream>> are supported.
144+
* Only indices in a <<tsds,time series data stream>> are supported.
135145

136146
* Data is downsampled based on the time dimension only. All other dimensions are
137147
copied to the new index without any modification.
138148

139149
* Within a data stream, a downsampled index replaces the original index and the
140-
original index is deleted. Only one index can exist for a given time period.
150+
original index is deleted. Only one index can exist for a given time period.
141151

142152
* A source index must be in read-only mode for the downsampling process to
143153
succeed. Check the <<downsampling-manual,Run downsampling manually>> example for

docs/reference/ilm/apis/get-lifecycle.asciidoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ If the request succeeds, the body of the response contains the policy definition
115115
}
116116
}
117117
--------------------------------------------------
118-
// TEST[skip:https://github.com/elastic/elasticsearch/issues/89623]
119118
// TESTRESPONSE[s/"modified_date": 82392349/"modified_date": $body.my_policy.modified_date/]
120119

121120
<1> The policy version is incremented whenever the policy is updated

0 commit comments

Comments
 (0)