refactor a bit

Author: jan-elastic

x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/autoscaling/MlAutoscalingContext.java

@@ -174,13 +174,6 @@ public boolean hasWaitingTasks() {
     }
 
     public boolean isEmpty() {
-        return anomalyDetectionTasks.isEmpty()
-            && snapshotUpgradeTasks.isEmpty()
-            && dataframeAnalyticsTasks.isEmpty()
-            && modelAssignments.isEmpty();
-    }
-
-    public boolean hasOnlyZeroAllocationModels() {
         return anomalyDetectionTasks.isEmpty()
             && snapshotUpgradeTasks.isEmpty()
             && dataframeAnalyticsTasks.isEmpty()

x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/autoscaling/MlAutoscalingDeciderService.java

@@ -131,7 +131,7 @@ public AutoscalingDeciderResult scale(Settings configuration, AutoscalingDecider
             .setPassedConfiguration(configuration);
 
         // We don't need to check anything as there are no tasks
-        if (mlContext.isEmpty() || mlContext.hasOnlyZeroAllocationModels()) {
+        if (mlContext.isEmpty()) {
             // This is a quick path to downscale.
             // simply return `0` for scale down if delay is satisfied
             return downscaleToZero(configuration, context, currentNativeMemoryCapacity, reasonBuilder);