Skip to content

Commit 3e97c87

Browse files
committed
Fix verifier tests
1 parent ec55b1b commit 3e97c87

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2484,28 +2484,25 @@ private void checkFullTextFunctionsInStats(String functionInvocation) {
24842484

24852485
public void testVectorSimilarityFunctionsNullArgs() throws Exception {
24862486
if (EsqlCapabilities.Cap.COSINE_VECTOR_SIMILARITY_FUNCTION.isEnabled()) {
2487-
checkVectorSimilarityFunctionsNullArgs("v_cosine(null, vector)", "first");
2488-
checkVectorSimilarityFunctionsNullArgs("v_cosine(vector, null)", "second");
2487+
checkVectorSimilarityFunctionsNullArgs("v_cosine(null, vector)");
2488+
checkVectorSimilarityFunctionsNullArgs("v_cosine(vector, null)");
24892489
}
24902490
if (EsqlCapabilities.Cap.DOT_PRODUCT_VECTOR_SIMILARITY_FUNCTION.isEnabled()) {
2491-
checkVectorSimilarityFunctionsNullArgs("v_dot_product(null, vector)", "first");
2492-
checkVectorSimilarityFunctionsNullArgs("v_dot_product(vector, null)", "second");
2491+
checkVectorSimilarityFunctionsNullArgs("v_dot_product(null, vector)");
2492+
checkVectorSimilarityFunctionsNullArgs("v_dot_product(vector, null)");
24932493
}
24942494
if (EsqlCapabilities.Cap.L1_NORM_VECTOR_SIMILARITY_FUNCTION.isEnabled()) {
2495-
checkVectorSimilarityFunctionsNullArgs("v_l1_norm(null, vector)", "first");
2496-
checkVectorSimilarityFunctionsNullArgs("v_l1_norm(vector, null)", "second");
2495+
checkVectorSimilarityFunctionsNullArgs("v_l1_norm(null, vector)");
2496+
checkVectorSimilarityFunctionsNullArgs("v_l1_norm(vector, null)");
24972497
}
24982498
if (EsqlCapabilities.Cap.L2_NORM_VECTOR_SIMILARITY_FUNCTION.isEnabled()) {
2499-
checkVectorSimilarityFunctionsNullArgs("v_l2_norm(null, vector)", "first");
2500-
checkVectorSimilarityFunctionsNullArgs("v_l2_norm(vector, null)", "second");
2499+
checkVectorSimilarityFunctionsNullArgs("v_l2_norm(null, vector)");
2500+
checkVectorSimilarityFunctionsNullArgs("v_l2_norm(vector, null)");
25012501
}
25022502
}
25032503

2504-
private void checkVectorSimilarityFunctionsNullArgs(String functionInvocation, String argOrdinal) throws Exception {
2505-
assertThat(
2506-
error("from test | eval similarity = " + functionInvocation, fullTextAnalyzer),
2507-
containsString(argOrdinal + " argument of [" + functionInvocation + "] cannot be null, received [null]")
2508-
);
2504+
private void checkVectorSimilarityFunctionsNullArgs(String functionInvocation) throws Exception {
2505+
query("from test | eval similarity = " + functionInvocation, fullTextAnalyzer);
25092506
}
25102507

25112508
private void query(String query) {

0 commit comments

Comments
 (0)