Add another test

Author: thecoop

test/framework/src/main/java/org/elasticsearch/search/rank/rerank/AbstractRerankerIT.java

@@ -496,7 +496,7 @@ public void testRankFeaturePhaseCoordinatorThrowingAllShardsFail() throws Except
         assertNoOpenContext(indexName);
     }
 
-    private void assertNoOpenContext(final String indexName) throws Exception {
+    protected void assertNoOpenContext(final String indexName) throws Exception {
         assertBusy(
             () -> assertThat(indicesAdmin().prepareStats(indexName).get().getTotal().getSearch().getOpenContexts(), equalTo(0L)),
             1,

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/rank/textsimilarity/TextSimilarityRankMultiNodeTests.java

@@ -15,6 +15,11 @@
 import java.util.Collection;
 import java.util.List;
 
+import static org.elasticsearch.index.query.QueryBuilders.boolQuery;
+import static org.elasticsearch.index.query.QueryBuilders.matchQuery;
+import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertHitCount;
+import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertNoFailuresAndResponse;
+
 public class TextSimilarityRankMultiNodeTests extends AbstractRerankerIT {
 
     private static final String inferenceId = "inference-id";
@@ -28,13 +33,22 @@ protected RankBuilder getRankBuilder(int rankWindowSize, String rankFeatureField
 
     @Override
     protected RankBuilder getThrowingRankBuilder(int rankWindowSize, String rankFeatureField, ThrowingRankBuilderType type) {
+        return getThrowingRankBuilder(rankWindowSize, rankFeatureField, type, false);
+    }
+
+    protected RankBuilder getThrowingRankBuilder(
+        int rankWindowSize,
+        String rankFeatureField,
+        ThrowingRankBuilderType type,
+        boolean failuresAllowed
+    ) {
         return new TextSimilarityTestPlugin.ThrowingMockRequestActionBasedRankBuilder(
             rankWindowSize,
             rankFeatureField,
             inferenceId,
             inferenceText,
             minScore,
-            false,
+            failuresAllowed,
             type.name()
         );
     }
@@ -52,6 +66,50 @@ public void testQueryPhaseCoordinatorThrowingAllShardsFail() throws Exception {
         // no-op
     }
 
+    public void testRerankerAllowedFailureNoExceptions() throws Exception {
+        final String indexName = "test_index";
+        final String rankFeatureField = "rankFeatureField";
+        final String searchField = "searchField";
+        final int rankWindowSize = 10;
+
+        createIndex(indexName);
+        indexRandom(
+            true,
+            prepareIndex(indexName).setId("1").setSource(rankFeatureField, 0.1, searchField, "A"),
+            prepareIndex(indexName).setId("2").setSource(rankFeatureField, 0.2, searchField, "B"),
+            prepareIndex(indexName).setId("3").setSource(rankFeatureField, 0.3, searchField, "C"),
+            prepareIndex(indexName).setId("4").setSource(rankFeatureField, 0.4, searchField, "D"),
+            prepareIndex(indexName).setId("5").setSource(rankFeatureField, 0.5, searchField, "E")
+        );
+
+        assertNoFailuresAndResponse(
+            prepareSearch().setQuery(
+                    boolQuery().should(matchQuery(searchField, "A"))
+                        .should(matchQuery(searchField, "B"))
+                        .should(matchQuery(searchField, "C"))
+                        .should(matchQuery(searchField, "D"))
+                        .should(matchQuery(searchField, "E"))
+                )
+                .setRankBuilder(
+                    getThrowingRankBuilder(
+                        rankWindowSize,
+                        rankFeatureField,
+                        ThrowingRankBuilderType.THROWING_RANK_FEATURE_PHASE_COORDINATOR_CONTEXT,
+                        true
+                    )
+                )
+                .addFetchField(searchField)
+                .setTrackTotalHits(true)
+                .setAllowPartialSearchResults(true)
+                .setSize(10),
+            response -> {
+                // just check it returns 5 documents, the order will be random due to not getting reranked
+                assertHitCount(response, 5L);
+            }
+        );
+        assertNoOpenContext(indexName);
+    }
+
     @Override
     protected boolean shouldCheckScores() {
         return false;

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/rank/textsimilarity/TextSimilarityTestPlugin.java

@@ -174,10 +174,10 @@ public ThrowingMockRequestActionBasedRankBuilder(
             String inferenceId,
             String inferenceText,
             Float minScore,
-            boolean lenient,
+            boolean failuresAllowed,
             String throwingType
         ) {
-            super(field, inferenceId, inferenceText, rankWindowSize, minScore, lenient);
+            super(field, inferenceId, inferenceText, rankWindowSize, minScore, failuresAllowed);
             this.throwingRankBuilderType = AbstractRerankerIT.ThrowingRankBuilderType.valueOf(throwingType);
         }