Skip to content

Commit 3fd8356

Browse files
georgewallacegeorgewallace
authored
Apply suggestions from code review
1 parent 3f10937 commit 3fd8356

File tree

13 files changed

+3
-51
lines changed

13 files changed

+3
-51
lines changed

‎docs/reference/elasticsearch/mapping-reference/search-as-you-type.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,12 @@ More subfields enables more specific queries but increases index size.
153153

154154
## Parameters of the field type as a text field [general-params]
155155

156-
The following parameters are accepted in a mapping for the `search_as_you_type` field due to its nature as a text-like field, and behave similarly to their behavior when configuring a field of the [`text`](text.md) data type. Unless otherwise noted, these options configure the root fields subfields in the same way.
156+
The following parameters are accepted in a mapping for the `search_as_you_type` field due to its nature as a text-like field, and behave similarly to their behavior when configuring a field of the [`text`](/reference/elasticsearch/mapping-reference/text.md) data type. Unless otherwise noted, these options configure the root fields subfields in the same way.
157157

158158
[`analyzer`](/reference/elasticsearch/mapping-reference/analyzer.md)
159159
: The [analyzer](docs-content://manage-data/data-store/text-analysis.md) which should be used for `text` fields, both at index-time and at search-time (unless overridden by the [`search_analyzer`](/reference/elasticsearch/mapping-reference/search-analyzer.md)). Defaults to the default index analyzer, or the [`standard` analyzer](/reference/data-analysis/text-analysis/analysis-standard-analyzer.md).
160160

161-
[`index`](mapping-index.md)
161+
[`index`](/reference/elasticsearch/mapping-reference/mapping-index.md)
162162
: Should the field be searchable? Accepts `true` (default) or `false`.
163163

164164
[`index_options`](index-options.md)

‎docs/reference/ingestion-tools/enrich-processor/sort-processor.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,5 @@ $$$sort-options$$$
3030
}
3131
}
3232
```
33-
3433
% NOTCONSOLE
3534

‎docs/reference/ingestion-tools/search-connectors/es-connectors-gmail.md‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ PUT _connector/my-gmail-connector
4949
"service_type": "gmail"
5050
}
5151
```
52-
5352
% TEST[skip:can’t test in isolation]
5453

5554
:::::{dropdown} You’ll also need to create an API key for the connector to use.
@@ -176,7 +175,6 @@ Download the sample configuration file. You can either download it manually or r
176175
```sh
177176
curl https://raw.githubusercontent.com/elastic/connectors/main/config.yml.example --output ~/connectors-config/config.yml
178177
```
179-
180178
% NOTCONSOLE
181179

182180
Remember to update the `--output` argument value if your directory name is different, or you want to use a different config file name.
@@ -268,7 +266,6 @@ For example:
268266
]
269267
}
270268
```
271-
272269
% NOTCONSOLE
273270

274271

‎docs/reference/ingestion-tools/search-connectors/es-connectors-onedrive.md‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ PUT _connector/my-onedrive-connector
5151
"service_type": "onedrive"
5252
}
5353
```
54-
5554
% TEST[skip:can’t test in isolation]
5655

5756
:::::{dropdown} You’ll also need to create an API key for the connector to use.
@@ -132,13 +131,12 @@ Self-managed connectors are run on your own infrastructure.
132131

133132
You can deploy the OneDrive connector as a self-managed connector using Docker. Follow these instructions.
134133

135-
::::{dropdown} **Step 1: Download sample configuration file**
134+
::::{dropdown} Step 1: Download sample configuration file
136135
Download the sample configuration file. You can either download it manually or run the following command:
137136

138137
```sh
139138
curl https://raw.githubusercontent.com/elastic/connectors/main/config.yml.example --output ~/connectors-config/config.yml
140139
```
141-
142140
% NOTCONSOLE
143141

144142
Remember to update the `--output` argument value if your directory name is different, or you want to use a different config file name.
@@ -315,7 +313,6 @@ This rule skips indexing for files with `.xlsx` and `.docx` extensions. All othe
315313
}
316314
]
317315
```
318-
319316
% NOTCONSOLE
320317

321318
$$$es-connectors-onedrive-client-sync-rules-advanced-examples-2$$$
@@ -331,7 +328,6 @@ This rule focuses on indexing files and folders owned by `user1-domain@onmicroso
331328
}
332329
]
333330
```
334-
335331
% NOTCONSOLE
336332

337333
$$$es-connectors-onedrive-client-sync-rules-advanced-examples-3$$$
@@ -347,7 +343,6 @@ This rule indexes only the files and folders directly inside the root folder, ex
347343
}
348344
]
349345
```
350-
351346
% NOTCONSOLE
352347

353348
$$$es-connectors-onedrive-client-sync-rules-advanced-examples-4$$$
@@ -364,7 +359,6 @@ This rule indexes files and folders owned by `[email protected]` and
364359
}
365360
]
366361
```
367-
368362
% NOTCONSOLE
369363

370364
$$$es-connectors-onedrive-client-sync-rules-advanced-examples-5$$$
@@ -382,7 +376,6 @@ This example contains two rules. The first rule indexes all files and folders ow
382376
}
383377
]
384378
```
385-
386379
% NOTCONSOLE
387380

388381
$$$es-connectors-onedrive-client-sync-rules-advanced-examples-6$$$
@@ -401,7 +394,6 @@ This example contains two rules. The first rule indexes all files owned by `user
401394
}
402395
]
403396
```
404-
405397
% NOTCONSOLE
406398

407399

‎docs/reference/ingestion-tools/search-connectors/es-connectors-redis.md‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ Download the sample configuration file. You can either download it manually or r
4343
```sh
4444
curl https://raw.githubusercontent.com/elastic/connectors/main/config.yml.example --output ~/connectors-config/config.yml
4545
```
46-
4746
% NOTCONSOLE
4847

4948
Remember to update the `--output` argument value if your directory name is different, or you want to use a different config file name.
@@ -221,7 +220,6 @@ Provide at least one of the following: `key_pattern` or `type`, or both.
221220
}
222221
]
223222
```
224-
225223
% NOTCONSOLE
226224

227225

@@ -237,7 +235,6 @@ Provide at least one of the following: `key_pattern` or `type`, or both.
237235
}
238236
]
239237
```
240-
241238
% NOTCONSOLE
242239

243240

@@ -252,7 +249,6 @@ Provide at least one of the following: `key_pattern` or `type`, or both.
252249
"key_pattern": "test[123]"
253250
}
254251
```
255-
256252
% NOTCONSOLE
257253

258254

@@ -268,7 +264,6 @@ Provide at least one of the following: `key_pattern` or `type`, or both.
268264
}
269265
]
270266
```
271-
272267
% NOTCONSOLE
273268

274269

@@ -284,7 +279,6 @@ Provide at least one of the following: `key_pattern` or `type`, or both.
284279
}
285280
]
286281
```
287-
288282
% NOTCONSOLE
289283

290284
#### Example 6 [es-connectors-redis-connector-advanced-sync-rules-example-6]
@@ -300,7 +294,6 @@ Provide at least one of the following: `key_pattern` or `type`, or both.
300294
}
301295
]
302296
```
303-
304297
% NOTCONSOLE
305298

306299

@@ -316,7 +309,6 @@ Provide at least one of the following: `key_pattern` or `type`, or both.
316309
}
317310
]
318311
```
319-
320312
% NOTCONSOLE
321313

322314

‎docs/reference/ingestion-tools/search-connectors/es-connectors-s3.md‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ PUT _connector/my-s3-connector
4444
"service_type": "s3"
4545
}
4646
```
47-
4847
% TEST[skip:can’t test in isolation]
4948

5049
:::::{dropdown} You’ll also need to create an API key for the connector to use.
@@ -170,7 +169,6 @@ Download the sample configuration file. You can either download it manually or r
170169
```sh
171170
curl https://raw.githubusercontent.com/elastic/connectors/main/config.yml.example --output ~/connectors-config/config.yml
172171
```
173-
174172
% NOTCONSOLE
175173

176174
Remember to update the `--output` argument value if your directory name is different, or you want to use a different config file name.
@@ -281,7 +279,6 @@ $$$es-connectors-s3-client-sync-rules-advanced-examples$$$
281279
282280
]
283281
```
284-
285282
% NOTCONSOLE
286283

287284
**Example**: Fetch files/folder starting with `folder1`.
@@ -294,7 +291,6 @@ $$$es-connectors-s3-client-sync-rules-advanced-examples$$$
294291
}
295292
]
296293
```
297-
298294
% NOTCONSOLE
299295

300296
**Fetching files and folders by specifying extensions**
@@ -310,7 +306,6 @@ $$$es-connectors-s3-client-sync-rules-advanced-examples$$$
310306
}
311307
]
312308
```
313-
314309
% NOTCONSOLE
315310

316311

‎docs/reference/ingestion-tools/search-connectors/es-connectors-salesforce.md‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ PUT _connector/my-salesforce-connector
5353
"service_type": "salesforce"
5454
}
5555
```
56-
5756
% TEST[skip:can’t test in isolation]
5857

5958
:::::{dropdown} You’ll also need to create an API key for the connector to use.
@@ -194,7 +193,6 @@ Download the sample configuration file. You can either download it manually or r
194193
```sh
195194
curl https://raw.githubusercontent.com/elastic/connectors/main/config.yml.example --output ~/connectors-config/config.yml
196195
```
197-
198196
% NOTCONSOLE
199197

200198
Remember to update the `--output` argument value if your directory name is different, or you want to use a different config file name.
@@ -379,7 +377,6 @@ $$$es-connectors-salesforce-client-sync-rules-advanced-fetch-query-language$$$
379377
}
380378
]
381379
```
382-
383380
% NOTCONSOLE
384381

385382
$$$es-connectors-salesforce-client-sync-rules-advanced-fetch-objects$$$
@@ -399,7 +396,6 @@ $$$es-connectors-salesforce-client-sync-rules-advanced-fetch-objects$$$
399396
}
400397
]
401398
```
402-
403399
% NOTCONSOLE
404400

405401
**Example**: Fetch documents for custom objects via SOQL and SOSL query.
@@ -416,7 +412,6 @@ $$$es-connectors-salesforce-client-sync-rules-advanced-fetch-objects$$$
416412
}
417413
]
418414
```
419-
420415
% NOTCONSOLE
421416

422417
$$$es-connectors-salesforce-client-sync-rules-advanced-fetch-standard-custom-fields$$$
@@ -432,7 +427,6 @@ $$$es-connectors-salesforce-client-sync-rules-advanced-fetch-standard-custom-fie
432427
}
433428
]
434429
```
435-
436430
% NOTCONSOLE
437431

438432
**Example**: Fetch documents with all custom fields for Connector object.
@@ -445,7 +439,6 @@ $$$es-connectors-salesforce-client-sync-rules-advanced-fetch-standard-custom-fie
445439
}
446440
]
447441
```
448-
449442
% NOTCONSOLE
450443

451444
**Example**: Fetch documents with all standard fields for Account object.
@@ -458,7 +451,6 @@ $$$es-connectors-salesforce-client-sync-rules-advanced-fetch-standard-custom-fie
458451
}
459452
]
460453
```
461-
462454
% NOTCONSOLE
463455

464456

‎docs/reference/ingestion-tools/search-connectors/es-sync-rules.md‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,6 @@ A sample apartment looks like this in the `.json` format:
234234
}
235235
}
236236
```
237-
238237
% NOTCONSOLE
239238

240239
The target data set should fulfill the following conditions:
@@ -305,7 +304,6 @@ Let’s assume that the apartment data is stored inside a MongoDB instance. For
305304
}
306305
]
307306
```
308-
309307
% NOTCONSOLE
310308

311309
To create these advanced sync rules navigate to the sync rules creation dialog and select the *Advanced rules* tab. You can now paste your aggregation pipeline into the input field under `aggregate.pipeline`:

‎docs/reference/query-languages/query-dsl-geo-polygon-query.md‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ GET /_search
3939
}
4040
}
4141
```
42-
4342
% TEST[warning:Deprecated field [geo_polygon] used, replaced by [[geo_shape] query where polygons are defined in geojson or wkt]]
4443

4544

@@ -83,7 +82,6 @@ GET /_search
8382
}
8483
}
8584
```
86-
8785
% TEST[warning:Deprecated field [geo_polygon] used, replaced by [[geo_shape] query where polygons are defined in geojson or wkt]]
8886

8987

@@ -114,7 +112,6 @@ GET /_search
114112
}
115113
}
116114
```
117-
118115
% TEST[warning:Deprecated field [geo_polygon] used, replaced by [[geo_shape] query where polygons are defined in geojson or wkt]]
119116

120117

@@ -143,7 +140,6 @@ GET /_search
143140
}
144141
}
145142
```
146-
147143
% TEST[warning:Deprecated field [geo_polygon] used, replaced by [[geo_shape] query where polygons are defined in geojson or wkt]]
148144

149145

‎docs/reference/query-languages/query-dsl-geo-shape-query.md‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ POST /example/_doc?refresh
4040
}
4141
}
4242
```
43-
4443
% TESTSETUP
4544

4645
The following query will find the point using {{es}}'s `envelope` GeoJSON extension:
@@ -89,7 +88,6 @@ PUT /example_points/_doc/1?refresh
8988
"location": [13.400544, 52.530286]
9089
}
9190
```
92-
9391
% TEST[continued]
9492

9593
Using the same query, the documents with matching `geo_point` fields are returned.
@@ -117,7 +115,6 @@ GET /example_points/_search
117115
}
118116
}
119117
```
120-
121118
% TEST[continued]
122119

123120
```console-result
@@ -150,7 +147,6 @@ GET /example_points/_search
150147
}
151148
}
152149
```
153-
154150
% TESTRESPONSE[s/"took" : 17/"took" : $body.took/]
155151

156152

0 commit comments

Comments
 (0)