Skip to content

Commit 3fea67d

Browse files
authored
ESQL: Multiple parameters in ungrouped aggs (#132375)
Adds support for multiple parameters to ungrouped aggregations. Relates to #108385
1 parent 98af2ef commit 3fea67d

File tree

68 files changed

+3209
-2643
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+3209
-2643
lines changed

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/AggregatorImplementer.java

Lines changed: 198 additions & 152 deletions
Large diffs are not rendered by default.

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/GroupingAggregatorImplementer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public GroupingAggregatorImplementer(
129129
default -> throw new IllegalArgumentException("combine must have 2, 3, or 4 parameters but was: " + combine);
130130
}
131131
// TODO support multiple parameters
132-
this.aggParam = AggregationParameter.create(combine.getParameters().getLast().asType());
132+
this.aggParam = AggregationParameter.create(combine.getParameters().getLast());
133133

134134
this.createParameters = init.getParameters()
135135
.stream()

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctBooleanAggregatorFunction.java

Lines changed: 45 additions & 37 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctBytesRefAggregatorFunction.java

Lines changed: 49 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctDoubleAggregatorFunction.java

Lines changed: 45 additions & 37 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)