Iter

Author: jordan-powers

server/src/main/java/org/elasticsearch/index/mapper/DocumentParserContext.java

@@ -672,6 +672,7 @@ public final DocumentParserContext createNestedContext(NestedObjectMapper nested
             // parent document's _id is not yet available.
             // So we just add the child document without the parent _id, then in TimeSeriesIdFieldMapper#postParse we set the _id on all
             // child documents once we've calculated it.
+            assert getRoutingFields().equals(RoutingFields.Noop.INSTANCE) == false;
         } else {
             throw new IllegalStateException("The root document of a nested document should have an _id field");
         }

server/src/main/java/org/elasticsearch/index/mapper/TimeSeriesIdFieldMapper.java

@@ -146,11 +146,12 @@ public void postParse(DocumentParserContext context) throws IOException {
         );
 
         // We need to add the uid or id to nested Lucene documents so that when a document gets deleted, the nested documents are
-        // also deleted. Usually this happens when the nested document is created (in DocumentParser#createNestedContext), but
+        // also deleted. Usually this happens when the nested document is created (in DocumentParserContext#createNestedContext), but
         // for time-series indices the _id isn't available at that point.
-        assert context.id() != null;
+        var binaryId = context.doc().getField(IdFieldMapper.NAME).binaryValue();
         for (LuceneDocument doc : context.nonRootDocuments()) {
-            doc.add(new StringField(IdFieldMapper.NAME, Uid.encodeId(context.id()), Field.Store.NO));
+            assert doc.getField(IdFieldMapper.NAME) == null;
+            doc.add(new StringField(IdFieldMapper.NAME, binaryId, Field.Store.NO));
         }
     }