Test adding checks

julian-elastic · julian-elastic · commit 4076106b0b74 · 2025-07-02T10:31:59.000-04:00
diff --git a/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/LocalLogicalPlanOptimizer.java b/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/LocalLogicalPlanOptimizer.java
@@ -85,12 +85,8 @@ private static Batch<LogicalPlan> localOperators() {
     }
 
     public LogicalPlan localOptimize(LogicalPlan plan) {
-        Failures failures = verifier.verify(plan);
-        if (failures.hasFailures()) {
-            throw new VerificationException("Plan before optimize not valid: " + failures + " for plan: " + plan.nodeString());
-        }
         LogicalPlan optimized = execute(plan);
-        failures = verifier.verify(optimized);
+        Failures failures = verifier.verify(optimized);
         if (failures.hasFailures()) {
             throw new VerificationException("Plan after optimize not valid: " + failures + " for plan: " + plan.nodeString());
         }

Original file line number	Diff line number	Diff line change
`@@ -85,12 +85,8 @@ private static Batch<LogicalPlan> localOperators() {`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`public LogicalPlan localOptimize(LogicalPlan plan) {`
`88`		`- Failures failures = verifier.verify(plan);`
`89`		`- if (failures.hasFailures()) {`
`90`		`- throw new VerificationException("Plan before optimize not valid: " + failures + " for plan: " + plan.nodeString());`
`91`		`- }`
`92`	`88`	`LogicalPlan optimized = execute(plan);`
`93`		`- failures = verifier.verify(optimized);`
	`89`	`+ Failures failures = verifier.verify(optimized);`
`94`	`90`	`if (failures.hasFailures()) {`
`95`	`91`	`throw new VerificationException("Plan after optimize not valid: " + failures + " for plan: " + plan.nodeString());`
`96`	`92`	`}`