tweaks

Author: thecoop

server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java

@@ -991,24 +991,30 @@ public abstract VectorData parseKnnVector(
 
         public abstract ByteBuffer createByteBuffer(IndexVersion indexVersion, int numBytes);
 
+        /**
+         * Checks the input {@code vector} is one of the {@code possibleTypes},
+         * and returns the first type that it matches
+         */
         public static ElementType checkValidVector(float[] vector, ElementType... possibleTypes) {
             assert possibleTypes.length != 0;
             // we're looking for one valid allowed type
             StringBuilder[] errors = new StringBuilder[possibleTypes.length];
             for (int i = 0; i < possibleTypes.length; i++) {
                 StringBuilder error = possibleTypes[i].checkVectorErrors(vector);
                 if (error == null) {
-                    // this one works - all ok
+                    // this one works - use it
                     return possibleTypes[i];
                 } else {
                     errors[i] = error;
                 }
             }
 
-            // oh dear, none of the types work with this vector. Generate the error message and throw.
+            // oh dear, none of the possible types work with this vector. Generate the error message and throw.
             StringBuilder message = new StringBuilder();
             for (int i = 0; i < possibleTypes.length; i++) {
-                if (i > 0) message.append(" ");
+                if (i > 0) {
+                    message.append(" ");
+                }
                 message.append("Vector is not a ").append(possibleTypes[i]).append(" vector: ").append(errors[i]);
             }
             throw new IllegalArgumentException(appendErrorElements(message, vector).toString());

server/src/main/java/org/elasticsearch/script/VectorScoreScriptUtils.java

@@ -138,7 +138,7 @@ public FloatDenseVectorFunction(
                 queryMagnitude += value * value;
             }
             queryMagnitude = Math.sqrt(queryMagnitude);
-            DenseVectorFieldMapper.ElementType.FLOAT.checkVectorBounds(this.queryVector);
+            field.getElementType().checkVectorBounds(this.queryVector);
 
             if (normalizeQuery) {
                 for (int dim = 0; dim < this.queryVector.length; dim++) {